Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/lib/PrintHandlers/PrintHandler.php

Summary

Maintainability
D
2 days
Test Coverage
B
84%

PrintHandler has 69 functions (exceeds 20 allowed). Consider refactoring.
Open

class PrintHandler {

    const BARCODE_UPCA      = 1;
    const BARCODE_UPCE      = 2;
    const BARCODE_EAN13     = 3;
Severity: Major
Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 1 day to fix

    File PrintHandler.php has 317 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace COREPOS\pos\lib\PrintHandlers;
use COREPOS\pos\lib\Bitmap;
use COREPOS\pos\lib\ReceiptLib;
    Severity: Minor
    Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 3 hrs to fix

      Function transposeBitmapData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          function transposeBitmapData($data, $width, $tallDots=false) 
    {
        $oldRowBytes = (int)(($width + 7) / 8);
        $newColBytes = $tallDots ? 1 : 3;
        $oldStripeSize = (int)($oldRowBytes * ($tallDots ? 8 : 24));
      Severity: Minor
      Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transposeBitmapData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function transposeBitmapData($data, $width, $tallDots=false) 
    {
        $oldRowBytes = (int)(($width + 7) / 8);
        $newColBytes = $tallDots ? 1 : 3;
        $oldStripeSize = (int)($oldRowBytes * ($tallDots ? 8 : 24));
      Severity: Minor
      Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 1 hr to fix

        Method renderBitmap has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function renderBitmap($arg, $align='C'){
        $slip = "";

        $bmp = null;
        if (is_object($arg) && is_a($arg, 'COREPOS\\pos\\lib\\Bitmap')){
        Severity: Minor
        Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 1 hr to fix

          Function renderBitmap has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              function renderBitmap($arg, $align='C'){
        $slip = "";

        $bmp = null;
        if (is_object($arg) && is_a($arg, 'COREPOS\\pos\\lib\\Bitmap')){
          Severity: Minor
          Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method rasterBitmap has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function rasterBitmap($data, $width, $height, $tallDots=false, $wideDots=false) {
          Severity: Minor
          Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 35 mins to fix

            Method textStyle has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function textStyle($altFont=false, $bold=false, $tall=false, $wide=false, $underline=false) {
            Severity: Minor
            Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function centerString($text)
    {
        $width = 59;

        $blank = str_repeat(" ", $width);
              Severity: Minor
              Found in pos/is4c-nf/lib/PrintHandlers/PrintHandler.php and 1 other location - About 50 mins to fix
              pos/is4c-nf/lib/PrintHandlers/EmailPrintHandler.php on lines 34..43

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status