Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php

Summary

Maintainability
D
2 days
Test Coverage
D
64%

Method handle has 159 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle($upc,$json)
    {
        list($manId, $fam, $val, $manIdStart) = $this->upcToParts($upc);

        $valueInfo = $this->getValue($val);
Severity: Major
Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 6 hrs to fix

    Function handle has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle($upc,$json)
    {
        list($manId, $fam, $val, $manIdStart) = $this->upcToParts($upc);

        $valueInfo = $this->getValue($val);
    Severity: Minor
    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File CouponCode.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010 Whole Foods Co-op
    Severity: Minor
    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 2 hrs to fix

      Method checkLimits has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function checkLimits($upc, $json)
    {
        $dbc = Database::pDataConnect();
        $query2 = "SELECT reason, threshold FROM disableCoupon WHERE upc='$upc'";
        $result2 = $dbc->query($query2);
      Severity: Minor
      Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 1 hr to fix

        Function checkLimits has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function checkLimits($upc, $json)
    {
        $dbc = Database::pDataConnect();
        $query2 = "SELECT reason, threshold FROM disableCoupon WHERE upc='$upc'";
        $result2 = $dbc->query($query2);
        Severity: Minor
        Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $json;
        Severity: Major
        Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $json;
          Severity: Major
          Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $json;
            Severity: Major
            Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $json;
              Severity: Major
              Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/CouponCode.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status