Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php

Summary

Maintainability
F
4 days
Test Coverage
F
28%

Method handle has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle($upc,$json)
    {
        $pos = 0;
        $coupon = new stdClass();
        $coupon->firstReq = new stdClass();
Severity: Major
Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 1 day to fix

    Function handle has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle($upc,$json)
    {
        $pos = 0;
        $coupon = new stdClass();
        $coupon->firstReq = new stdClass();
    Severity: Minor
    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File DatabarCoupon.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2010 Whole Foods Co-op
    Severity: Minor
    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 4 hrs to fix

      Method validateRequirement has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function validateRequirement($req, $json)
    {
        // non-existant requirement is treated as valid
        if (!property_exists($req, 'value')) {
            $req->valid = true;
      Severity: Major
      Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 3 hrs to fix

        Function validateRequirement has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function validateRequirement($req, $json)
    {
        // non-existant requirement is treated as valid
        if (!property_exists($req, 'value')) {
            $req->valid = true;
        Severity: Minor
        Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return $json;
        Severity: Major
        Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $this->validateQty($row['qty'], $row['couponqtty'], $req, $json);
          Severity: Major
          Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $json;
            Severity: Major
            Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->validateQty($row['total'], $row['couponqtty'], $req, $json);
              Severity: Major
              Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return array($req, $json);
                Severity: Major
                Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return array($req, $json);
                  Severity: Major
                  Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $json;
                    Severity: Major
                    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return $json;
                      Severity: Major
                      Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return array($req, $json); // requirement validated
                        Severity: Major
                        Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return $json;
                          Severity: Major
                          Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return $json;
                            Severity: Major
                            Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return $json;
                              Severity: Major
                              Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                    return $json;
                                Severity: Major
                                Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return array($req, $json);
                                  Severity: Major
                                  Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php - About 30 mins to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                if ($smLength == 15) { // 9+6
                $coupon->secondReq->prefix = $coupon->firstReq->prefix;
                $coupon->dupePrefixFlag = true;
            } else {
                $coupon->secondReq->prefix = substr($upc,$pos,$smLength);
                                    Severity: Minor
                                    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php and 1 other location - About 55 mins to fix
                                    pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php on lines 217..227

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 98.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                if ($tmLength == 15) { // 9+6
                $coupon->thirdReq->prefix = $coupon->firstReq->prefix;
                $coupon->dupePrefixFlag = true;
            } else {
                $coupon->thirdReq->prefix = substr($upc,$pos,$tmLength);
                                    Severity: Minor
                                    Found in pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php and 1 other location - About 55 mins to fix
                                    pos/is4c-nf/lib/Scanning/SpecialUPCs/DatabarCoupon.php on lines 186..196

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 98.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status