pos/is4c-nf/lib/Tenders/CheckTender.php
Function errorCheck
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
public function errorCheck()
{
$clearButton = array(_('OK [clear]') => 'parseWrapper(\'CL\');');
if ( CoreLocal::get("isMember") != 0 && (($this->amount - CoreLocal::get("amtdue") - 0.005) > CoreLocal::get("dollarOver")) && (CoreLocal::get("cashOverLimit") == 1)) {
return DisplayLib::boxMsg(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method errorCheck
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function errorCheck()
{
$clearButton = array(_('OK [clear]') => 'parseWrapper(\'CL\');');
if ( CoreLocal::get("isMember") != 0 && (($this->amount - CoreLocal::get("amtdue") - 0.005) > CoreLocal::get("dollarOver")) && (CoreLocal::get("cashOverLimit") == 1)) {
return DisplayLib::boxMsg(
Consider simplifying this complex logical expression. Open
Open
if ( CoreLocal::get("isMember") != 0 && (($this->amount - CoreLocal::get("amtdue") - 0.005) > CoreLocal::get("dollarOver")) && (CoreLocal::get("cashOverLimit") == 1)) {
return DisplayLib::boxMsg(
_("member check tender cannot exceed total purchase by over $") . CoreLocal::get("dollarOver"),
'',
false,
Avoid too many return
statements within this method. Open
Open
return true;