Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/lib/Tenders/TenderModule.php

Summary

Maintainability
D
1 day
Test Coverage
B
82%

Function errorCheck has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function errorCheck()
    {
        //force negative entered value when the total is negative.
        if (CoreLocal::get("amtdue") <0 && $this->amount >= 0) {
            $this->amount = -1 * $this->amount;
Severity: Minor
Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method errorCheck has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function errorCheck()
    {
        //force negative entered value when the total is negative.
        if (CoreLocal::get("amtdue") <0 && $this->amount >= 0) {
            $this->amount = -1 * $this->amount;
Severity: Major
Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 2 hrs to fix

    Method frankingPrompt has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function frankingPrompt()
    {
        if (CoreLocal::get("enableFranking") != 1) {
            /*
             * This is the same as defaultPrompt() above,
    Severity: Minor
    Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              } else if ($this->name_string === "") {
            return DisplayLib::inputUnknown();
        } elseif (CoreLocal::get('fntlflag') && CoreLocal::get('fsEligible') < 0 && abs($this->amount - CoreLocal::get('fsEligible')) < 0.005) {
            // not actually an error
            // if return tender exactly matches FS elgible return amount
      Severity: Major
      Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 1 hr to fix

        Function preReqCheck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function preReqCheck()
    {
        if ($this->amount > $this->max_limit && CoreLocal::get("msgrepeat") == 0) {
            CoreLocal::set("boxMsg",
                "$" . $this->amount . " " . _("is greater than tender limit for") . " " . $this->name_string
        Severity: Minor
        Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return DisplayLib::xboxMsg(
                _("Why are you using a negative number for a positive sale?"),
                $clearButton
            );
        Severity: Major
        Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return DisplayLib::boxMsg(
                "$" . $this->amount . " " . _("is greater than tender limit for") . " " . $this->name_string,
                '',
                false,
                $clearButton
            Severity: Major
            Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return DisplayLib::inputUnknown();
              Severity: Major
              Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return DisplayLib::xboxMsg(
                _("return tender must be exact"),
                $clearButton
            );
                Severity: Major
                Found in pos/is4c-nf/lib/Tenders/TenderModule.php - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (CoreLocal::get("enableFranking") != 1) {
            /*
             * This is the same as defaultPrompt() above,
             * but the inheritence structure makes calling
             * it trickier than it should be
                  Severity: Major
                  Found in pos/is4c-nf/lib/Tenders/TenderModule.php and 1 other location - About 2 hrs to fix
                  pos/is4c-nf/lib/Tenders/TenderModule.php on lines 250..264

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 131.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function defaultPrompt()
    {
        $amt = $this->DefaultTotal();
        CoreLocal::set('boxMsg',
            '<br />'
                  Severity: Major
                  Found in pos/is4c-nf/lib/Tenders/TenderModule.php and 1 other location - About 2 hrs to fix
                  pos/is4c-nf/lib/Tenders/TenderModule.php on lines 284..302

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 131.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status