CORE-POS/IS4C

View on GitHub
pos/is4c-nf/lib/gui/BasicCorePage.php

Summary

Maintainability
C
1 day
Test Coverage
B
81%

File BasicCorePage.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2007,2010 Whole Foods Co-op

Severity: Minor
Found in pos/is4c-nf/lib/gui/BasicCorePage.php - About 2 hrs to fix

    Function commonHeader has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function commonHeader()
        {
            $myUrl = $this->page_url;
            $this->add_onload_command("betterDate();\n\$('#reginput').focus();");
    
    
    Severity: Minor
    Found in pos/is4c-nf/lib/gui/BasicCorePage.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method commonHeader has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function commonHeader()
        {
            $myUrl = $this->page_url;
            $this->add_onload_command("betterDate();\n\$('#reginput').focus();");
    
    
    Severity: Minor
    Found in pos/is4c-nf/lib/gui/BasicCorePage.php - About 1 hr to fix

      Function change_page has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function change_page($url)
          {
              if ($this->session->get("Debug_Redirects") == 1){
                  $stack = debug_backtrace();
                  printf('Follow redirect to <a href="%s">%s</a>',$url,$url);
      Severity: Minor
      Found in pos/is4c-nf/lib/gui/BasicCorePage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method dateJS has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function dateJS()
          {
              return <<<JAVASCRIPT
              <script type="text/javascript">
              function betterDate() {
      Severity: Minor
      Found in pos/is4c-nf/lib/gui/BasicCorePage.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status