Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/parser/parse/Totals.php

Summary

Maintainability
B
5 hrs
Test Coverage
A
97%

Method finalttl has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function finalttl() 
    {
        if ($this->session->get("percentDiscount") > 0) {
            TransRecord::addRecord(array(
                'description' => 'Discount',
Severity: Minor
Found in pos/is4c-nf/parser/parse/Totals.php - About 1 hr to fix

    Function parse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        function parse($str)
    {
        $ret = $this->default_json();
        if ($str == "FNTL"){
            $ret['main_frame'] = MiscLib::baseURL().'gui-modules/fsTotalConfirm.php';
    Severity: Minor
    Found in pos/is4c-nf/parser/parse/Totals.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function parse($str)
    {
        $ret = $this->default_json();
        if ($str == "FNTL"){
            $ret['main_frame'] = MiscLib::baseURL().'gui-modules/fsTotalConfirm.php';
    Severity: Minor
    Found in pos/is4c-nf/parser/parse/Totals.php - About 1 hr to fix

      Method doc has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function doc(){
        return "<table cellspacing=0 cellpadding=3 border=1>
            <tr>
                <th>Input</th><th>Result</th>
            </tr>
      Severity: Minor
      Found in pos/is4c-nf/parser/parse/Totals.php - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if ($str == "FNTL" || $str == "TETL" ||
            $str == "FTTL" || $str == "TL" ||
            $str == "MTL" || $str == "WICTL" ||
            substr($str,0,2) == "FN")
            return True;
        Severity: Major
        Found in pos/is4c-nf/parser/parse/Totals.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status