Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/CoopCred/CoopCredTender.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method errorCheck has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function errorCheck()
    {
        global $CORE_LOCAL;

        $this->conn = CoopCredLib::ccDataConnect();
Severity: Major
Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 2 hrs to fix

    Function errorCheck has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function errorCheck()
    {
        global $CORE_LOCAL;

        $this->conn = CoopCredLib::ccDataConnect();
    Severity: Minor
    Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function preReqCheck has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function preReqCheck()
    {
        global $CORE_LOCAL;
        $pref = CoreState::getCustomerPref('store_charge_see_id');
        if ($pref == 'yes') {
    Severity: Minor
    Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return DisplayLib::xboxMsg(
                _("The amount of Coop Cred tendered may not exceed the Amount Due."));
    Severity: Major
    Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return DisplayLib::xboxMsg(
                _("The amount of Coop Cred you have in ").
                '<b>'.  $CORE_LOCAL->get("{$pc}programName"). '</b>' .
                _(" is only \$") .
                number_format($memChargeCommitted,2) .
        Severity: Major
        Found in pos/is4c-nf/plugins/CoopCred/CoopCredTender.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status