Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/MoneyGram/MGScreen.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method body_content has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function body_content() 
    {
        $msg = $this->step == 0 ? _('Transasction Type') : _('Enter Amount');
        $stem = MiscLib::baseURL() . 'graphics/';
        ?>
Severity: Minor
Found in pos/is4c-nf/plugins/MoneyGram/MGScreen.php - About 1 hr to fix

    Method preprocess has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function preprocess()
    {
        /**
          The "selectlist" field is on the step==0 screen
          to choose a transaction type. Clear from this screen
    Severity: Minor
    Found in pos/is4c-nf/plugins/MoneyGram/MGScreen.php - About 1 hr to fix

      Function preprocess has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          function preprocess()
    {
        /**
          The "selectlist" field is on the step==0 screen
          to choose a transaction type. Clear from this screen
      Severity: Minor
      Found in pos/is4c-nf/plugins/MoneyGram/MGScreen.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function body_content has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          function body_content() 
    {
        $msg = $this->step == 0 ? _('Transasction Type') : _('Enter Amount');
        $stem = MiscLib::baseURL() . 'graphics/';
        ?>
      Severity: Minor
      Found in pos/is4c-nf/plugins/MoneyGram/MGScreen.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in pos/is4c-nf/plugins/MoneyGram/MGScreen.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status