Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/BasicCCModule.php

Summary

Maintainability
C
1 day
Test Coverage

Method curlSend has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function curlSend($data=False,$type='POST',$xml=False, $extraOpts=array(), $autoHandle=true)
    {
        if($data && $type == 'GET') {
            $this->GATEWAY .= $data;
        }
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/BasicCCModule.php - About 2 hrs to fix

    File BasicCCModule.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*******************************************************************************

    Copyright 2007 Whole Foods Co-op
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/BasicCCModule.php - About 2 hrs to fix

      Function curlSend has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function curlSend($data=False,$type='POST',$xml=False, $extraOpts=array(), $autoHandle=true)
    {
        if($data && $type == 'GET') {
            $this->GATEWAY .= $data;
        }
      Severity: Minor
      Found in pos/is4c-nf/plugins/Paycards/BasicCCModule.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method curlSend has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function curlSend($data=False,$type='POST',$xml=False, $extraOpts=array(), $autoHandle=true)
      Severity: Minor
      Found in pos/is4c-nf/plugins/Paycards/BasicCCModule.php - About 35 mins to fix

        Function getErrorText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getErrorText($title, $code, $flags, $type) 
    {
        $opts = array();
        if ($flags['retry']) $opts[] = "<b>retry</b>"; 
        if ($flags['standalone']) $opts[] = "process in <b>standalone</b>";
        Severity: Minor
        Found in pos/is4c-nf/plugins/Paycards/BasicCCModule.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status