Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/GoEMerchant.php

Summary

Maintainability
F
6 days
Test Coverage

File GoEMerchant.php has 651 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2007,2010 Whole Foods Co-op
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 1 day to fix

    Method lookupTransaction has 156 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function lookupTransaction($ref, $local, $mode)
    {
        $merchantID = $this->conf->get('GoEMerchID');
        $password = $this->conf->get('GoEMerchPassword');
        $gatewayID = $this->conf->get('GoEmerchGatewayID');
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 6 hrs to fix

      Method sendAuth has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function sendAuth()
    {
        // initialize
        $dbTrans = PaycardLib::paycard_db();
        if (!$dbTrans) {
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 4 hrs to fix

        Function lookupTransaction has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
        Open

            public function lookupTransaction($ref, $local, $mode)
    {
        $merchantID = $this->conf->get('GoEMerchID');
        $password = $this->conf->get('GoEMerchPassword');
        $gatewayID = $this->conf->get('GoEmerchGatewayID');
        Severity: Minor
        Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method sendVoid has 96 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function sendVoid()
    {
        // initialize
        $dbTrans = PaycardLib::paycard_db();
        if (!$dbTrans) {
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 3 hrs to fix

          Method handleResponseAuth has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function handleResponseAuth($authResult)
    {
        $xml = new XmlData($authResult['response']);
        $dbTrans = PaycardLib::paycard_db();
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 3 hrs to fix

            Method handleResponseVoid has 64 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function handleResponseVoid($authResult)
    {
        $xml = new XmlData($authResult['response']);
        // prepare some fields to store the parsed response; we'll add more as we verify it
        $now = date('Y-m-d H:i:s'); // full timestamp
            Severity: Major
            Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 2 hrs to fix

              Function handleResponseAuth has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function handleResponseAuth($authResult)
    {
        $xml = new XmlData($authResult['response']);
        $dbTrans = PaycardLib::paycard_db();
              Severity: Minor
              Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function handleResponseVoid has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function handleResponseVoid($authResult)
    {
        $xml = new XmlData($authResult['response']);
        // prepare some fields to store the parsed response; we'll add more as we verify it
        $now = date('Y-m-d H:i:s'); // full timestamp
              Severity: Minor
              Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method cleanup has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function cleanup($json)
    {
        switch ($this->conf->get("paycard_mode")) {
            case PaycardLib::PAYCARD_MODE_AUTH:
                // cast to string. tender function expects string input
              Severity: Minor
              Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 1 hr to fix

                Function sendAuth has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function sendAuth()
    {
        // initialize
        $dbTrans = PaycardLib::paycard_db();
        if (!$dbTrans) {
                Severity: Minor
                Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function cleanup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function cleanup($json)
    {
        switch ($this->conf->get("paycard_mode")) {
            case PaycardLib::PAYCARD_MODE_AUTH:
                // cast to string. tender function expects string input
                Severity: Minor
                Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function sendVoid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function sendVoid()
    {
        // initialize
        $dbTrans = PaycardLib::paycard_db();
        if (!$dbTrans) {
                Severity: Minor
                Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function refnum($transID)
    {
        $transNo   = (int)$this->conf->get("transno");
        $cashierNo = (int)$this->conf->get("CashierNo");
        $laneNo    = (int)$this->conf->get("laneno");
                Severity: Major
                Found in pos/is4c-nf/plugins/Paycards/GoEMerchant.php and 1 other location - About 5 hrs to fix
                pos/is4c-nf/plugins/Paycards/FirstData.php on lines 299..314

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 194.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status