Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/ValueLink.php

Summary

Maintainability
F
1 wk
Test Coverage

File ValueLink.php has 588 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2007,2010 Whole Foods Co-op
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 1 day to fix

    Method sendVoid has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function sendVoid()
    {
        $this->GATEWAY = 'https://api.payeezy.com/v1/transactions/' . $authcode;
        $this->GATEWAY = 'https://api.globalgatewaye4.firstdata.com/transaction/v32';
        if ($this->conf->get("training") == 1) {
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 3 hrs to fix

      Method handleResponseAuth has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function handleResponseAuth($authResult)
    {
        $json = json_decode($authResult['response'], true);

        // initialize
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 3 hrs to fix

        Method sendAuth has 74 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function sendAuth()
    {
        $this->GATEWAY = 'https://api.payeezy.com/v1/transactions';
        $this->GATEWAY = 'https://api.globalgatewaye4.firstdata.com/transaction/v32';
        if ($this->conf->get("training") == 1) {
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 2 hrs to fix

          Method handleResponseVoid has 62 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function handleResponseVoid($vdResult)
    {
        $json = json_decode($vdResult['response'], true);

        // initialize
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 2 hrs to fix

            Function handleResponseAuth has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                private function handleResponseAuth($authResult)
    {
        $json = json_decode($authResult['response'], true);

        // initialize
            Severity: Minor
            Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cleanup has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function cleanup($json)
    {
        switch ($this->conf->get("paycard_mode")) {
            case PaycardLib::PAYCARD_MODE_BALANCE:
                $resp = $this->conf->get("paycard_response");
            Severity: Major
            Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 2 hrs to fix

              Method entered has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function entered($validate,$json)
    {
        try {
            $this->dialogs->enabledCheck();
              Severity: Minor
              Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 1 hr to fix

                Method handleResponseBalance has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function handleResponseBalance($balResult)
    {
        $json = json_decode($balResult['response'], true);

        if ($balResult['curlErr'] != CURLE_OK) {
                Severity: Minor
                Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 1 hr to fix

                  Function handleResponseBalance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function handleResponseBalance($balResult)
    {
        $json = json_decode($balResult['response'], true);

        if ($balResult['curlErr'] != CURLE_OK) {
                  Severity: Minor
                  Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method sendBalance has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function sendBalance($domain="w1.mercurypay.com")
    {
        $this->GATEWAY = 'https://api.globalgatewaye4.firstdata.com/transaction/v32';
        if ($this->conf->get("training") == 1) {
            $this->GATEWAY = 'https://api.demo.globalgatewaye4.firstdata.com/transaction/v32';
                  Severity: Minor
                  Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 1 hr to fix

                    Function handleResponseVoid has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function handleResponseVoid($vdResult)
    {
        $json = json_decode($vdResult['response'], true);

        // initialize
                    Severity: Minor
                    Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function entered has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function entered($validate,$json)
    {
        try {
            $this->dialogs->enabledCheck();
                    Severity: Minor
                    Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function sendAuth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function sendAuth()
    {
        $this->GATEWAY = 'https://api.payeezy.com/v1/transactions';
        $this->GATEWAY = 'https://api.globalgatewaye4.firstdata.com/transaction/v32';
        if ($this->conf->get("training") == 1) {
                    Severity: Minor
                    Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                                    return $json;
                    Severity: Major
                    Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return PaycardLib::PAYCARD_ERR_PROC;
                      Severity: Major
                      Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return PaycardLib::PAYCARD_ERR_PROC;
                        Severity: Major
                        Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return $json;
                          Severity: Major
                          Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return $this->curlSend($msgJson, 'POST', false, $extraHeaders);
                            Severity: Major
                            Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 30 mins to fix

                              Function sendVoid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function sendVoid()
    {
        $this->GATEWAY = 'https://api.payeezy.com/v1/transactions/' . $authcode;
        $this->GATEWAY = 'https://api.globalgatewaye4.firstdata.com/transaction/v32';
        if ($this->conf->get("training") == 1) {
                              Severity: Minor
                              Found in pos/is4c-nf/plugins/Paycards/ValueLink.php - About 25 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function entered($validate,$json)
    {
        try {
            $this->dialogs->enabledCheck();
                              Severity: Major
                              Found in pos/is4c-nf/plugins/Paycards/ValueLink.php and 1 other location - About 2 days to fix
                              pos/is4c-nf/plugins/Paycards/MercuryGift.php on lines 76..136

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 505.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function cleanup($json)
    {
        switch ($this->conf->get("paycard_mode")) {
            case PaycardLib::PAYCARD_MODE_BALANCE:
                $resp = $this->conf->get("paycard_response");
                              Severity: Major
                              Found in pos/is4c-nf/plugins/Paycards/ValueLink.php and 1 other location - About 2 days to fix
                              pos/is4c-nf/plugins/Paycards/MercuryGift.php on lines 172..226

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 467.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  public function paycardVoid($transID,$laneNo=-1,$transNo=-1,$json=array()) 
    {
        $this->voidTrans = "";
        $this->voidRef = "";
        $ret = $this->pmod->ccVoid($transID, $laneNo, $transNo, $json);
                              Severity: Major
                              Found in pos/is4c-nf/plugins/Paycards/ValueLink.php and 2 other locations - About 1 hr to fix
                              pos/is4c-nf/plugins/Paycards/MercuryGift.php on lines 233..244
                              pos/is4c-nf/plugins/Paycards/Valutec.php on lines 189..200

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 110.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status