Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/Valutec.php

Summary

Maintainability
F
3 days
Test Coverage

File Valutec.php has 440 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*******************************************************************************

    Copyright 2007,2010 Whole Foods Co-op
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 6 hrs to fix

    Function handleResponseAuth has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleResponseAuth($authResult)
    {
        $xml = new XmlData($authResult["response"]);
        $request = $this->last_request;
        $this->last_paycard_transaction_id = $request->last_paycard_transaction_id;
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleResponseAuth has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleResponseAuth($authResult)
    {
        $xml = new XmlData($authResult["response"]);
        $request = $this->last_request;
        $this->last_paycard_transaction_id = $request->last_paycard_transaction_id;
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 2 hrs to fix

      Method sendAuth has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function sendAuth()
    {
        // initialize
        $dbTrans = Database::tDataConnect();
        if (!$dbTrans) {
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 2 hrs to fix

        Method cleanup has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function cleanup($json)
    {
        switch ($this->conf->get("paycard_mode")) {
            case PaycardLib::PAYCARD_MODE_BALANCE:
                $resp = $this->conf->get("paycard_response");
        Severity: Minor
        Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 2 hrs to fix

          Method handleResponseVoid has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function handleResponseVoid($vdResult)
    {
        $xml = new XmlData($vdResult["response"]);
        $request = $this->last_request;
        $this->last_paycard_transaction_id = $request->last_paycard_transaction_id;
          Severity: Minor
          Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                    if ($xml->isValid()
            && $xml->get('TRANSACTIONTYPE') && $xml->get('TRANSACTIONTYPE') == 'Gift'
            && $xml->get('AUTHORIZED') && $xml->get('AUTHORIZED') == 'true'
            && (!$xml->get('ERRORMSG') || $xml->get_first('ERRORMSG') == '')
            && $xml->get('BALANCE')
            Severity: Critical
            Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 1 hr to fix

              Method sendVoid has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function sendVoid()
    {
        // initialize
        $dbTrans = Database::tDataConnect();
        if (!$dbTrans) {
              Severity: Minor
              Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 1 hr to fix

                Method entered has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function entered($validate,$json)
    {
        try {
            $this->dialogs->enabledCheck();
            // error checks based on processing mode
                Severity: Minor
                Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 1 hr to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if ($end !== false && $end > $begin) {
                            $balance = trim(urldecode(substr($rawOutput,$begin+9,($end-$begin)-9)));
                        }
                  Severity: Major
                  Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 45 mins to fix

                    Function sendAuth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function sendAuth()
    {
        // initialize
        $dbTrans = Database::tDataConnect();
        if (!$dbTrans) {
                    Severity: Minor
                    Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function handleResponseVoid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function handleResponseVoid($vdResult)
    {
        $xml = new XmlData($vdResult["response"]);
        $request = $this->last_request;
        $this->last_paycard_transaction_id = $request->last_paycard_transaction_id;
                    Severity: Minor
                    Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return $json;
                    Severity: Major
                    Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $json;
                      Severity: Major
                      Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 30 mins to fix

                        Function handleResponseBalance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function handleResponseBalance($balResult)
    {
        $xml = new XmlData($balResult["response"]);

        $comm = $this->pmod->commError($balResult);
                        Severity: Minor
                        Found in pos/is4c-nf/plugins/Paycards/Valutec.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                            public function paycardVoid($transID,$laneNo=-1,$transNo=-1,$json=array()) 
    {
        $this->voidTrans = "";
        $this->voidRef = "";
        $ret = $this->pmod->ccVoid($transID, $laneNo, $transNo, $json);
                        Severity: Major
                        Found in pos/is4c-nf/plugins/Paycards/Valutec.php and 2 other locations - About 1 hr to fix
                        pos/is4c-nf/plugins/Paycards/MercuryGift.php on lines 233..244
                        pos/is4c-nf/plugins/Paycards/ValueLink.php on lines 226..237

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 110.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status