Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/card/CardValidator.php

Summary

Maintainability
B
5 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (!is_numeric($amt) || abs($amt) < 0.005) {
            return array(false, 'Enter a different amount');
        } elseif ($amt > 0 && $due < 0) {
            return array(false, 'Enter a negative amount');
        } elseif ($amt < 0 && $due > 0) {
Severity: Critical
Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 1 hr to fix

    Function validateAmount has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function validateAmount($conf)
    {
        $amt = $conf->get('paycard_amount');
        $due = $conf->get("amtdue");
        $type = $conf->get("CacheCardType");
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validExpiration has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function validExpiration($exp) 
    {
        // verify expiration format (MMYY)
        if( strlen($exp) != 4 || !ctype_digit($exp))
            return -1;
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return 1;
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return array(false, 'Cannot exceed card balance');
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return array(true, 'valid');
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return array(false, 'Cannot exceed amount due plus cashback');
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/card/CardValidator.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status