CORE-POS/IS4C

View on GitHub
pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php

Summary

Maintainability
C
1 day
Test Coverage

Function preprocess has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function preprocess()
    {
        $this->conf = new PaycardConf();
        $this->bmpPath = $this->page_url . 'scale-drivers/drivers/NewMagellan/ss-output/tmp/';
        $this->capture = new SigCapture($this->conf);
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method head_content has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function head_content(){
        ?>
        <script type="text/javascript">
        var formSubmitted = false;
        function submitWrapper(){
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 2 hrs to fix

    Method body_content has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function body_content()
        {
            $this->input_header("onsubmit=\"return submitWrapper();\" action=\"".AutoLoader::ownURL()."\"");
            echo '<div class="baseHeight">';
            if ($this->capture->required()) {
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 1 hr to fix

      Method preprocess has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function preprocess()
          {
              $this->conf = new PaycardConf();
              $this->bmpPath = $this->page_url . 'scale-drivers/drivers/NewMagellan/ss-output/tmp/';
              $this->capture = new SigCapture($this->conf);
      Severity: Minor
      Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 1 hr to fix

        Function body_content has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            function body_content()
            {
                $this->input_header("onsubmit=\"return submitWrapper();\" action=\"".AutoLoader::ownURL()."\"");
                echo '<div class="baseHeight">';
                if ($this->capture->required()) {
        Severity: Minor
        Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if( $input == "") { // [enter] exits this screen
                        // remember the mode, type and transid before we reset them
                        $this->conf->set("boxMsg","");
        
                        /**
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvSuccess.php - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status