Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php

Summary

Maintainability
F
3 days
Test Coverage

Function getItemData has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    private function getItemData($arr)
    {
        $ret = '';
        /**
          Convert balance to a more useful format.
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getItemData has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getItemData($arr)
    {
        $ret = '';
        /**
          Convert balance to a more useful format.
Severity: Major
Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 3 hrs to fix

    File PaycardEmvWic.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * This page does not really have a UI and just exists
 * to run javascript and process responses. It flows like this:
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 3 hrs to fix

      Method head_content has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function head_content()
    {
        $url = MiscLib::baseURL();
        echo '<script type="text/javascript" src="' . $url . '/js/singleSubmit.js"></script>';
        echo '<script type="text/javascript" src="../js/emv.js?date=20210325"></script>';
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 2 hrs to fix

        Function preprocess has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            function preprocess()
    {
        // I haven't tracked down the cause but some mechanisms for getting here
        // do NOT unset msgrepeat which leads to an approval immediately triggering
        // into another ewic transaction
        Severity: Minor
        Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method preprocess has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function preprocess()
    {
        // I haven't tracked down the cause but some mechanisms for getting here
        // do NOT unset msgrepeat which leads to an approval immediately triggering
        // into another ewic transaction
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 2 hrs to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($manu != '00000' && !isset($couponCache[$manu])) {
                $couponApplied = $dbc->getValue($appliedP, array($row['upc']));
                if ($couponApplied) {
                    $couponValue = $dbc->getValue($couponP, array('005' . $manu . '%'));
                    $row['ttl'] += $couponValue; // coupons are negative
            Severity: Major
            Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php and 1 other location - About 1 hr to fix
            pos/is4c-nf/lib/ReceiptBuilding/Messages/WicReceiptMessage.php on lines 60..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($arr as $balanceRecord) {
            if (isset($balanceRecord['subcat']) && $balanceRecord['qty'] > 0) {
                $key = $balanceRecord['cat']['eWicCategoryID']
                    . ':' . $balanceRecord['subcat']['eWicSubCategoryID'];
                $categories[$key] = $balanceRecord['qty'];
            Severity: Major
            Found in pos/is4c-nf/plugins/Paycards/gui/PaycardEmvWic.php and 1 other location - About 1 hr to fix
            pos/is4c-nf/lib/ReceiptBuilding/Messages/WicReceiptMessage.php on lines 31..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status