Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php

Summary

Maintainability
F
3 days
Test Coverage

Function body_content has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    function body_content()
    {
        echo '<div class="baseHeight">';
        // generate message to print
        $amt = $this->conf->get("paycard_amount");
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method body_content has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function body_content()
    {
        echo '<div class="baseHeight">';
        // generate message to print
        $amt = $this->conf->get("paycard_amount");
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php - About 1 hr to fix

    Function preprocess has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        function preprocess()
    {
        // check for posts before drawing anything, so we can redirect
        $this->addOnloadCommand("\$('#formlocal').submit(paycardboxmsgAuth.submitWrapper);\n");
        $cval = new CardValidator();
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method preprocess has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function preprocess()
    {
        // check for posts before drawing anything, so we can redirect
        $this->addOnloadCommand("\$('#formlocal').submit(paycardboxmsgAuth.submitWrapper);\n");
        $cval = new CardValidator();
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if ($valid === false) {
            echo PaycardLib::paycardMsgBox("Invalid Amount: $amt",
                $validmsg, "[clear] to cancel");
        } elseif ($balanceLimit > 0) {
            $msg = "Tender ".PaycardLib::moneyFormat($amt);
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php and 1 other location - About 1 day to fix
      pos/is4c-nf/plugins/Paycards/gui/PaycardEmvPage.php on lines 172..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 394.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

                  if ($input === "CL") {
                $this->conf->set("msgrepeat",0);
                $this->conf->set("toggletax",0);
                $this->conf->set("togglefoodstamp",0);
                $this->conf->reset();
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/gui/paycardboxMsgAuth.php and 3 other locations - About 3 hrs to fix
      pos/is4c-nf/plugins/Paycards/gui/PaycardEmvGift.php on lines 57..80
      pos/is4c-nf/plugins/Paycards/gui/PaycardEmvPage.php on lines 44..87
      pos/is4c-nf/plugins/Paycards/gui/PaycardEmvRecurring.php on lines 42..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status