Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php

Summary

Maintainability
D
2 days
Test Coverage

Method getTenderLine has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getTenderLine($trans, $transID)
    {
        // look up the transaction tender line-item
        $sql = "SELECT trans_type,
                    trans_subtype,
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php - About 1 hr to fix

    Method getResponse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getResponse($trans, $transID)
    {
        $today = date('Ymd');
        $sql = "SELECT commErr,
                    httpCode,
    Severity: Minor
    Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php - About 1 hr to fix

      Method getRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getRequest($trans, $transID)
    {
        $today = date('Ymd');
        // look up the request using transID (within this transaction)
        $sql = "SELECT live,
      Severity: Minor
      Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if ($lineitem['trans_type'] != "T" || ($lineitem['trans_subtype'] != "CC" && $lineitem['trans_subtype'] != 'DC'
            && $lineitem['trans_subtype'] != 'EF' && $lineitem['trans_subtype'] != 'EC' && $lineitem['trans_subtype'] != 'AX') ) {
            $error = _("Authorization and tender records do not match ");
        } elseif ($lineitem['trans_status'] == "V" || $lineitem['voided'] != 0) {
            $error = _("Void records do not match");
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getRequest($trans, $transID)
    {
        $today = date('Ymd');
        // look up the request using transID (within this transaction)
        $sql = "SELECT live,
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php and 1 other location - About 6 hrs to fix
          pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php on lines 146..178

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 208.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getResponse($trans, $transID)
    {
        $today = date('Ymd');
        $sql = "SELECT commErr,
                    httpCode,
          Severity: Major
          Found in pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php and 1 other location - About 6 hrs to fix
          pos/is4c-nf/plugins/Paycards/lib/PaycardDialogs.php on lines 111..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 208.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status