Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getTenderConfig has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getTenderConfig($type)
    { 
        switch ($type) {
            case 'DEBIT':
                return array(
Severity: Minor
Found in pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return array(
                    array($this->conf->get('PaycardsTenderCodeGift')),
                    'GD',
                    'Gift Card',
                );
    Severity: Major
    Found in pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return array(
                    array($this->conf->get('PaycardsTenderCodeCredit')),
                    'CC',
                    'Credit Card',
                );
      Severity: Major
      Found in pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php - About 30 mins to fix

          Function getIssuerOverride has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getIssuerOverride($issuer)
    {
        if ($this->conf->get('PaycardsTenderCodeVisa') && $issuer == 'Visa') {
            return array($this->conf->get('PaycardsTenderCodeVisa'));
        } elseif ($this->conf->get('PaycardsTenderCodeMC') && $issuer == 'MasterCard') {
          Severity: Minor
          Found in pos/is4c-nf/plugins/Paycards/lib/PaycardTenders.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status