Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/plugins/WicPlugin/WicParser.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method wicUPC has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function wicUPC($str)
    {
        $dbc = Database::tDataConnect();
        $dbc->query('UPDATE localtemptrans SET percentDiscount=0');
        $arr = CoreLocal::get('WicOverride');
Severity: Minor
Found in pos/is4c-nf/plugins/WicPlugin/WicParser.php - About 1 hr to fix

    Function wicUPC has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function wicUPC($str)
    {
        $dbc = Database::tDataConnect();
        $dbc->query('UPDATE localtemptrans SET percentDiscount=0');
        $arr = CoreLocal::get('WicOverride');
    Severity: Minor
    Found in pos/is4c-nf/plugins/WicPlugin/WicParser.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (substr($str, -3) == 'WIC' && is_numeric(substr($str, 0, strlen($str)-3))) {
            $this->mode = 'etender';
        } elseif (CoreLocal::get('WicMode') === 2 && $str != 'WIC') {
            return false;
        } elseif (CoreLocal::get('WicMode') && is_numeric($str) && strlen($str) < 15 && !$this->wicUPC($str)) {
    Severity: Major
    Found in pos/is4c-nf/plugins/WicPlugin/WicParser.php - About 1 hr to fix

      Function check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function check($str)
    {
        if (substr($str, -3) == 'WIC' && is_numeric(substr($str, 0, strlen($str)-3))) {
            $this->mode = 'etender';
        } elseif (CoreLocal::get('WicMode') === 2 && $str != 'WIC') {
      Severity: Minor
      Found in pos/is4c-nf/plugins/WicPlugin/WicParser.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $ret;
      Severity: Major
      Found in pos/is4c-nf/plugins/WicPlugin/WicParser.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status