CORE-POS/IS4C

View on GitHub
pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Bson/BsonReader.cs

Summary

Maintainability
F
4 days
Test Coverage

File BsonReader.cs has 646 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
using System.IO;

    Method ReadType has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void ReadType(BsonType type)
            {
                switch (type)
                {
                    case BsonType.Number:

      Class BsonReader has 30 methods (exceeds 20 allowed). Consider refactoring.
      Open

          public class BsonReader : JsonReader
          {
              private const int MaxCharBytesSize = 128;
              private static readonly byte[] SeqRange1 = new byte[] { 0, 127 }; // range of 1-byte sequence
              private static readonly byte[] SeqRange2 = new byte[] { 194, 223 }; // range of 2-byte sequence

        Method ReadNormal has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private bool ReadNormal()
                {
                    switch (CurrentState)
                    {
                        case State.Start:

          Method ReadReference has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private bool ReadReference()
                  {
                      switch (CurrentState)
                      {
                          case State.ObjectStart:

            Method ReadString has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private string ReadString()
                    {
                        EnsureBuffers();
            
                        StringBuilder builder = null;

              Method GetString has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      private string GetString(int length)
                      {
                          if (length == 0)
                              return string.Empty;
              
              

                Method ReadCodeWScope has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        private bool ReadCodeWScope()
                        {
                            switch (_bsonReaderState)
                            {
                                case BsonReaderState.CodeWScopeStart:

                  Method ReadInternal has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          internal override bool ReadInternal()
                          {
                              try
                              {
                                  bool success;

                    Method GetLastFullCharStop has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private int GetLastFullCharStop(int start)
                            {
                                int lookbackPos = start;
                                int bis = 0;
                                while (lookbackPos >= 0)

                      Avoid too many return statements within this method.
                      Open

                                  return false;

                        Avoid too many return statements within this method.
                        Open

                                                return true;

                          Avoid too many return statements within this method.
                          Open

                                      return 0;

                            Avoid too many return statements within this method.
                            Open

                                                    return true;

                              Avoid too many return statements within this method.
                              Open

                                                          return true;

                                Method ReadString has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                                Open

                                        private string ReadString()
                                        {
                                            EnsureBuffers();
                                
                                            StringBuilder builder = null;

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                case BsonType.Object:
                                                {
                                                    SetToken(JsonToken.StartObject);
                                
                                                    ContainerContext newContext = new ContainerContext(BsonType.Object);
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Bson/BsonReader.cs on lines 529..537

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 66.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                case BsonType.Array:
                                                {
                                                    SetToken(JsonToken.StartArray);
                                
                                                    ContainerContext newContext = new ContainerContext(BsonType.Array);
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Bson/BsonReader.cs on lines 520..528

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 66.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status