CORE-POS/IS4C

View on GitHub
pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/JsonWriter.cs

Summary

Maintainability
F
6 days
Test Coverage

File JsonWriter.cs has 1038 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.IO;
#if !(NET20 || NET35 || PORTABLE40 || PORTABLE)
using System.Numerics;

    Class JsonWriter has 90 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public abstract class JsonWriter : IDisposable
        {
            internal enum State
            {
                Start = 0,

      Method WriteValue has 148 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              internal static void WriteValue(JsonWriter writer, PrimitiveTypeCode typeCode, object value)
              {
                  switch (typeCode)
                  {
                      case PrimitiveTypeCode.Char:

        Method WriteTokenInternal has 92 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private void WriteTokenInternal(JsonToken tokenType, object value)
                {
                    switch (tokenType)
                    {
                        case JsonToken.None:

          Method AutoCompleteClose has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private void AutoCompleteClose(JsonContainerType type)
                  {
                      // write closing symbol and calculate new state
                      int levelsToComplete = 0;
          
          

            Method SetWriteState has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    protected void SetWriteState(JsonToken token, object value)
                    {
                        switch (token)
                        {
                            case JsonToken.StartObject:

              Method BuildStateArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      internal static State[][] BuildStateArray()
                      {
                          var allStates = StateArrayTempate.ToList();
                          var errorStates = StateArrayTempate[0];
                          var valueStates = StateArrayTempate[7];

                Consider simplifying this complex logical expression.
                Open

                                if ((_currentState == State.Array || _currentState == State.ArrayStart || _currentState == State.Constructor || _currentState == State.ConstructorStart)
                                    || (tokenBeingWritten == JsonToken.PropertyName && _currentState != State.Start))
                                    WriteIndent();

                  Method AutoCompleteClose has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                          private void AutoCompleteClose(JsonContainerType type)
                          {
                              // write closing symbol and calculate new state
                              int levelsToComplete = 0;
                  
                  

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          public string Path
                          {
                              get
                              {
                                  if (_currentPosition.Type == JsonContainerType.None)
                  pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/JsonReader.cs on lines 264..281

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 112.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status