File ConvertUtils.cs has 645 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Globalization;
using System.ComponentModel;
#if !(NET20 || NET35 || PORTABLE40 || PORTABLE)Method TryConvertInternal has 127 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static ConvertResult TryConvertInternal(object initialValue, CultureInfo culture, Type targetType, out object value)
{
if (initialValue == null)
throw new ArgumentNullException("initialValue");
Method TryConvertInternal has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring. Open
private static ConvertResult TryConvertInternal(object initialValue, CultureInfo culture, Type targetType, out object value)
{
if (initialValue == null)
throw new ArgumentNullException("initialValue");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class ConvertUtils has 22 methods (exceeds 20 allowed). Consider refactoring. Open
internal static class ConvertUtils
{
private static readonly Dictionary<Type, PrimitiveTypeCode> TypeCodeMap =
new Dictionary<Type, PrimitiveTypeCode>
{Method Int32TryParse has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static ParseResult Int32TryParse(char[] chars, int start, int length, out int value)
{
value = 0;
if (length == 0)Method Int64TryParse has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static ParseResult Int64TryParse(char[] chars, int start, int length, out long value)
{
value = 0;
if (length == 0)Method Int32TryParse has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring. Open
public static ParseResult Int32TryParse(char[] chars, int start, int length, out int value)
{
value = 0;
if (length == 0)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Int64TryParse has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring. Open
public static ParseResult Int64TryParse(char[] chars, int start, int length, out long value)
{
value = 0;
if (length == 0)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return new BigInteger((long)value);Avoid too many return statements within this method. Open
return ConvertResult.CannotConvertNull;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.NoValidConversion;Avoid too many return statements within this method. Open
return ParseResult.Overflow;Avoid too many return statements within this method. Open
return ParseResult.Success;Avoid too many return statements within this method. Open
return ParseResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.NotInstantiableType;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return new BigInteger((ulong)value);Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ToValue((SqlString)nullableValue);Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ParseResult.Overflow;Avoid too many return statements within this method. Open
return new BigInteger((decimal)value);Avoid too many return statements within this method. Open
return new BigInteger((uint)value);Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ParseResult.Overflow;Avoid too many return statements within this method. Open
return new BigInteger((byte[])value);Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ParseResult.Overflow;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return ToValue((SqlDateTime)nullableValue);Avoid too many return statements within this method. Open
return ConvertResult.Success;Avoid too many return statements within this method. Open
return System.Convert.ChangeType((long)i, targetType, CultureInfo.InvariantCulture);Avoid too many return statements within this method. Open
return new BigInteger((int)value);Avoid too many return statements within this method. Open
return ConvertResult.Success;Similar blocks of code found in 2 locations. Consider refactoring. Open
public static ParseResult Int32TryParse(char[] chars, int start, int length, out int value)
{
value = 0;
if (length == 0)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 285.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static ParseResult Int64TryParse(char[] chars, int start, int length, out long value)
{
value = 0;
if (length == 0)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 285.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76