CORE-POS/IS4C

View on GitHub
pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs

Summary

Maintainability
F
4 days
Test Coverage

File ReflectionUtils.cs has 781 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
#if !(PORTABLE || PORTABLE40 || NET35 || NET20)
using System.Numerics;
#endif

    Class ReflectionUtils has 43 methods (exceeds 20 allowed). Consider refactoring.
    Open

        internal static class ReflectionUtils
        {
            public static readonly Type[] EmptyTypes;
    
            static ReflectionUtils()

      Method GetChildPrivateProperties has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
      Open

              private static void GetChildPrivateProperties(IList<PropertyInfo> initialProperties, Type targetType, BindingFlags bindingAttr)
              {
                  // fix weirdness with private PropertyInfos only being returned for the current Type
                  // find base type properties and add them to result
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method GetAttributes has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static Attribute[] GetAttributes(object attributeProvider, Type attributeType, bool inherit)
              {
                  ValidationUtils.ArgumentNotNull(attributeProvider, "attributeProvider");
      
                  object provider = attributeProvider;

        Method GetChildPrivateProperties has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private static void GetChildPrivateProperties(IList<PropertyInfo> initialProperties, Type targetType, BindingFlags bindingAttr)
                {
                    // fix weirdness with private PropertyInfos only being returned for the current Type
                    // find base type properties and add them to result
        
        

          Method GetDefaultValue has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public static object GetDefaultValue(Type type)
                  {
                      if (!type.IsValueType())
                          return null;
          
          

            Method RemoveAssemblyDetails has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private static string RemoveAssemblyDetails(string fullyQualifiedTypeName)
                    {
                        StringBuilder builder = new StringBuilder();
            
                        // loop through the type name and filter out qualified assembly details from nested type names

              Method ImplementsGenericDefinition has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public static bool ImplementsGenericDefinition(Type type, Type genericInterfaceDefinition, out Type implementingType)
                      {
                          ValidationUtils.ArgumentNotNull(type, "type");
                          ValidationUtils.ArgumentNotNull(genericInterfaceDefinition, "genericInterfaceDefinition");
              
              

                Method GetFieldsAndProperties has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        public static List<MemberInfo> GetFieldsAndProperties(Type type, BindingFlags bindingAttr)
                        {
                            List<MemberInfo> targetMembers = new List<MemberInfo>();
                
                            targetMembers.AddRange(GetFields(type, bindingAttr));

                  Method GetTypeName has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          public static string GetTypeName(Type t, FormatterAssemblyStyle assemblyFormat, SerializationBinder binder)
                          {
                              string fullyQualifiedTypeName;
                  #if !(NET20 || NET35)
                              if (binder != null)

                    Avoid too many return statements within this method.
                    Open

                                    return false;

                      Avoid too many return statements within this method.
                      Open

                                      return (attributeType != null) ? Attribute.GetCustomAttributes(p, attributeType, inherit) : Attribute.GetCustomAttributes(p, inherit);

                        Avoid too many return statements within this method.
                        Open

                                    return (Attribute[])result;

                          Avoid too many return statements within this method.
                          Open

                                          return false;

                            Avoid too many return statements within this method.
                            Open

                                        return true;

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                          if (provider is MemberInfo)
                                          {
                                              MemberInfo m = (MemberInfo)provider;
                                              return (attributeType != null) ? Attribute.GetCustomAttributes(m, attributeType, inherit) : Attribute.GetCustomAttributes(m, inherit);
                                          }
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 721..725
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 728..732

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 62.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                          if (provider is ParameterInfo)
                                          {
                                              ParameterInfo p = (ParameterInfo)provider;
                                              return (attributeType != null) ? Attribute.GetCustomAttributes(p, attributeType, inherit) : Attribute.GetCustomAttributes(p, inherit);
                                          }
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 714..718
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 721..725

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 62.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                          if (provider is Module)
                                          {
                                              Module m = (Module)provider;
                                              return (attributeType != null) ? Attribute.GetCustomAttributes(m, attributeType, inherit) : Attribute.GetCustomAttributes(m, inherit);
                                          }
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 714..718
                              pos/is4c-nf/scale-drivers/drivers/NewMagellan/Newtonsoft.Json/Utilities/ReflectionUtils.cs on lines 728..732

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 62.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status