File SPH_IngenicoRBA_Common.cs
has 830 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.IO.Ports;
using System.Threading;
using System.Collections;
using System.Collections.Generic;
Method HandleMessageFromDevice
has a Cognitive Complexity of 77 (exceeds 20 allowed). Consider refactoring. Open
public void HandleMessageFromDevice(byte[] buffer)
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
if (this.verbose_mode > 0) {
System.Console.WriteLine("Received:");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method HandleMessageFromDevice
has 121 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void HandleMessageFromDevice(byte[] buffer)
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
if (this.verbose_mode > 0) {
System.Console.WriteLine("Received:");
Class SPH_IngenicoRBA_Common
has 30 methods (exceeds 20 allowed). Consider refactoring. Open
public abstract class SPH_IngenicoRBA_Common : SerialPortHandler
{
protected byte[] last_message;
/** not used with on-demand implementation
private string terminal_serial_number;
Method ParseAuthMessage
has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected void ParseAuthMessage(byte[] msg)
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
// skipping 0 (stx), 1-3 (message #)
Method GetCashBack
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected byte[] GetCashBack()
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
byte[] form_name = enc.GetBytes("cashb.K3Z");
byte[] msg = new byte[79];
Method BuildImage
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
public string BuildImage(string path){
List<Point> points = new List<Point>();
List<byte> byteList = new List<byte>();
for(int i=0;i<sig_length;i++){
Method DrawSignatureImage
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
private string DrawSignatureImage(List<Point> Points,string path){
int width=512;
int height=128;
Bitmap bmp = new Bitmap(width, height);
Method HandleMsg
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
override public void HandleMsg(String msg)
{
// optional predicate for "termSig" message
// predicate string is displayed on sig capture screen
if (msg.Length > 7 && msg.Substring(0, 7) == "termSig") {
Method BuildImage
has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring. Open
public string BuildImage(string path){
List<Point> points = new List<Point>();
List<byte> byteList = new List<byte>();
for(int i=0;i<sig_length;i++){
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method ParseSigBlockMessage
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected void ParseSigBlockMessage(int status, byte[] msg)
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
if (status == 2) {
Method PinEntryScreen
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected byte[] PinEntryScreen()
{
System.Text.ASCIIEncoding enc = new System.Text.ASCIIEncoding();
byte[] pan = enc.GetBytes(masked_pan);
byte[] form = enc.GetBytes("pin.K3Z");
Similar blocks of code found in 3 locations. Consider refactoring. Open
protected byte[] HardResetMessage()
{
byte[] msg = new byte[5];
msg[0] = 0x2; // STX
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 101.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
protected byte[] StatusRequestMessage()
{
byte[] msg = new byte[5];
msg[0] = 0x2; // STX
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 101.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
protected byte[] RebootMessage()
{
byte[] msg = new byte[5];
msg[0] = 0x2; // STX
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 101.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
} else if (!auto_state_change && !getting_signature && (msg == "termGetType" || msg == "termGetTypeWithFS")) {
WriteMessageToDevice(GetCardType());
Thread.Sleep(2000);
char fs = (char)0x1c;
string buttons = "Bbtna,S"+fs+"Bbtnb,S"+fs+"Bbtnc,S"+fs+"Bbtnd,S";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 86.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (auto_state_change) {
WriteMessageToDevice(GetCardType());
Thread.Sleep(2000);
char fs = (char)0x1c;
string buttons = "Bbtna,S"+fs+"Bbtnb,S"+fs+"Bbtnc,S"+fs+"Bbtnd,S";
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 86.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76