Sign upLogin

CORE-POS/IS4C

View on GitHub
Star
pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs

Summary

Maintainability
F
3 days
Test Coverage

Method ParseData has a Cognitive Complexity of 60 (exceeds 20 allowed). Consider refactoring.
Open

    private string ParseData(string s)
    {
        if (s.Substring(0,1) == "0") { // scanner message
            if (s.Substring(0,3) == "08A" || s.Substring(0,3) == "08F") { // UPC-A or EAN-13
                return s.Substring(3);
Severity: Minor
Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ParseData has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private string ParseData(string s)
    {
        if (s.Substring(0,1) == "0") { // scanner message
            if (s.Substring(0,3) == "08A" || s.Substring(0,3) == "08F") { // UPC-A or EAN-13
                return s.Substring(3);
Severity: Major
Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 2 hrs to fix

    Method Read has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override public void Read()
    {
        string buffer = "";
        if (this.verbose_mode > 0) {
            System.Console.WriteLine("Reading serial data");
    Severity: Minor
    Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 1 hr to fix

      Method Read has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

          override public void Read()
    {
        string buffer = "";
        if (this.verbose_mode > 0) {
            System.Console.WriteLine("Reading serial data");
      Severity: Minor
      Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return s; // catch all
      Severity: Major
      Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return "S142";
        Severity: Major
        Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return null;
          Severity: Major
          Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return s.Substring(4);
            Severity: Major
            Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return "S11"+s.Substring(3);
              Severity: Major
              Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return "S"+s;
                Severity: Major
                Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return "S145";
                  Severity: Major
                  Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return "S110000";
                    Severity: Major
                    Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return s.Substring(4);
                      Severity: Major
                      Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return "S141";
                        Severity: Major
                        Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return "S"+s; // catch all
                          Severity: Major
                          Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return s; // catch all
                            Severity: Major
                            Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return "S140";
                              Severity: Major
                              Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs - About 30 mins to fix

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                        if (s.Substring(0,1) == "0") { // scanner message
            if (s.Substring(0,3) == "08A" || s.Substring(0,3) == "08F") { // UPC-A or EAN-13
                return s.Substring(3);
            } else if (s.Substring(0,3) == "08E") { // UPC-E
                return this.ExpandUPCE(s.Substring(3));
                                Severity: Major
                                Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs and 2 other locations - About 3 hrs to fix
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_Magellan_Scale.cs on lines 195..211
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_Magellan_ScanOnly.cs on lines 112..128

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 255.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 3 locations. Consider refactoring.
                                Open

                                    private string ExpandUPCE(string upc)
    {
        string lead = upc.Substring(0,upc.Length-1);
        string tail = upc.Substring(upc.Length-1);
                                Severity: Major
                                Found in pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_NCR_Scale.cs and 2 other locations - About 3 hrs to fix
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_Magellan_Scale.cs on lines 282..296
                                pos/is4c-nf/scale-drivers/drivers/NewMagellan/SPH_Magellan_ScanOnly.cs on lines 135..149

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 217.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status