Sign upLogin

CSCfi/pebbles

View on GitHub
Star
pebbles/drivers/provisioning/openshift_template_driver.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function render_template_objects has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def render_template_objects(self, namespace, application_session):
        """ Render the template for the application session. This is done on OpenShift server.
        """
        application_config = application_session['provisioning_config']
Severity: Minor
Found in pebbles/drivers/provisioning/openshift_template_driver.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function do_deprovision has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def do_deprovision(self, token, application_session_id):
        """ Implements deprovisioning, called by superclass.
            Iterates through template object types, queries them by label and deletes all objects.
        """
        application_session = self.fetch_and_populate_application_session(token, application_session_id)
Severity: Minor
Found in pebbles/drivers/provisioning/openshift_template_driver.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            env_var_dict = {k: v for k, v in [x.split('=') for x in env_var_array]}
Severity: Minor
Found in pebbles/drivers/provisioning/openshift_template_driver.py and 1 other location - About 30 mins to fix
pebbles/drivers/provisioning/kubernetes_driver.py on lines 372..372

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            client = self.dynamic_client.resources.get(
                api_version=template_object['apiVersion'],
                kind=template_object['kind']
Severity: Minor
Found in pebbles/drivers/provisioning/openshift_template_driver.py and 1 other location - About 30 mins to fix
pebbles/drivers/provisioning/openshift_template_driver.py on lines 48..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                client = self.dynamic_client.resources.get(
                    api_version=template_object['apiVersion'],
                    kind=template_object['kind']
Severity: Minor
Found in pebbles/drivers/provisioning/openshift_template_driver.py and 1 other location - About 30 mins to fix
pebbles/drivers/provisioning/openshift_template_driver.py on lines 130..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status