Sign upLogin

CSCfi/pebbles

View on GitHub
Star
pebbles/views/application_sessions.py

Summary

Maintainability
D
3 days
Test Coverage

File application_sessions.py has 338 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
import json
import logging

import flask_restful as restful
Severity: Minor
Found in pebbles/views/application_sessions.py - About 4 hrs to fix

    Function patch has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def patch(self, application_session_id):
        user = g.user

        # check that the user has rights to access the session
        opts = dict(application_session_id=application_session_id)
    Severity: Minor
    Found in pebbles/views/application_sessions.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function patch has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def patch(self, application_session_id):
        patch_parser = reqparse.RequestParser()
        patch_parser.add_argument('log_record', type=dict)
        args = patch_parser.parse_args()
    Severity: Minor
    Found in pebbles/views/application_sessions.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function post has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def post(self):
        user = g.user

        form = ApplicationSessionForm()
        if not form.validate_on_submit():
    Severity: Minor
    Found in pebbles/views/application_sessions.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    return 'There is already an existing session for this application', 409
    Severity: Major
    Found in pebbles/views/application_sessions.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 'Concurrent session memory limit for workspace exceeded', 409
      Severity: Major
      Found in pebbles/views/application_sessions.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return marshal_based_on_role(user, application_session), 200
        Severity: Major
        Found in pebbles/views/application_sessions.py - About 30 mins to fix

          Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def get(self):
        user = g.user

        args = self.list_parser.parse_args()
        s = rules.generate_application_session_query(user, args)
          Severity: Minor
          Found in pebbles/views/application_sessions.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          application_session_fields_manager = {
    'id': fields.String,
    'name': fields.String,
    'created_at': fields.DateTime(dt_format='iso8601'),
    'provisioned_at': fields.DateTime(dt_format='iso8601'),
          Severity: Major
          Found in pebbles/views/application_sessions.py and 1 other location - About 5 hrs to fix
          pebbles/views/application_sessions.py on lines 64..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          application_session_fields_user = {
    'id': fields.String,
    'name': fields.String,
    'created_at': fields.DateTime(dt_format='iso8601'),
    'provisioned_at': fields.DateTime(dt_format='iso8601'),
          Severity: Major
          Found in pebbles/views/application_sessions.py and 1 other location - About 5 hrs to fix
          pebbles/views/application_sessions.py on lines 42..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status