Sign upLogin

CSCfi/pebbles

View on GitHub
Star
pebbles/views/sessions.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function post has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def post(self):
        parser = reqparse.RequestParser()
        parser.add_argument('agreement_sign', type=str, default=False)
        args = parser.parse_args()
        form = SessionCreateForm()
Severity: Minor
Found in pebbles/views/sessions.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return marshal({
Severity: Major
Found in pebbles/views/sessions.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return 'Invalid user or password', 401
    Severity: Major
    Found in pebbles/views/sessions.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 'Account has expired', 403
      Severity: Major
      Found in pebbles/views/sessions.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status