Sign upLogin

CSCfi/pebbles

View on GitHub
Star
pebbles/views/sso.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function oauth2_login has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

def oauth2_login():
    parser = reqparse.RequestParser()
    parser.add_argument('agreement_sign', type=str, default=False, location='args')
    args = parser.parse_args()
    if not current_app.config['OAUTH2_LOGIN_ENABLED']:
Severity: Minor
Found in pebbles/views/sso.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function oauth2_login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def oauth2_login():
    parser = reqparse.RequestParser()
    parser.add_argument('agreement_sign', type=str, default=False, location='args')
    args = parser.parse_args()
    if not current_app.config['OAUTH2_LOGIN_ENABLED']:
Severity: Minor
Found in pebbles/views/sso.py - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status