Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
ReadModels/ContingentTravelPlanQueries.cs

Summary

Maintainability
C
1 day
Test Coverage

File ContingentTravelPlanQueries.cs has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using Edument.CQRS;
using Events.Contingent;
using Events.Tournament;
using System;
using System.Collections.Generic;
Severity: Minor
Found in ReadModels/ContingentTravelPlanQueries.cs - About 2 hrs to fix

    Method Handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public void Handle(TravelPlansChanged e)
        {
            var tournament = GetTournamentFromContingentId(e.Id);

            var travelPlans = e.TravelPlans.Select(travelPlan => new TravelPlan
    Severity: Minor
    Found in ReadModels/ContingentTravelPlanQueries.cs - About 1 hr to fix

      Method Handle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public void Handle(RoomCheckinChanged e)
        {
            var tournament = GetTournamentFromContingentId(e.Id);

            var contingentRooms = tournament.ContingentRooms.FirstOrDefault(x => x.Id == e.Id);
      Severity: Minor
      Found in ReadModels/ContingentTravelPlanQueries.cs - About 1 hr to fix

        Method Handle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public void Handle(RoomTypeChanged e)
        {
            var tournament = GetTournamentFromContingentId(e.Id);

            var contingentRooms = tournament.ContingentRooms.FirstOrDefault(x => x.Id == e.Id);
        Severity: Minor
        Found in ReadModels/ContingentTravelPlanQueries.cs - About 1 hr to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (contingentRooms == null)
            {
                var contingent = Contingents.Single(x => x.Key == e.Id);
                contingentRooms = new ContingentRooms
                {
          Severity: Major
          Found in ReadModels/ContingentTravelPlanQueries.cs and 2 other locations - About 50 mins to fix
          ReadModels/ContingentTravelPlanQueries.cs on lines 254..263
          ReadModels/ContingentTravelPlanQueries.cs on lines 289..298

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (contingentRooms == null)
            {
                var contingent = Contingents.Single(x => x.Key == e.Id);
                contingentRooms = new ContingentRooms
                {
          Severity: Major
          Found in ReadModels/ContingentTravelPlanQueries.cs and 2 other locations - About 50 mins to fix
          ReadModels/ContingentTravelPlanQueries.cs on lines 222..231
          ReadModels/ContingentTravelPlanQueries.cs on lines 254..263

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (contingentRooms == null)
            {
                var contingent = Contingents.Single(x => x.Key == e.Id);
                contingentRooms = new ContingentRooms
                {
          Severity: Major
          Found in ReadModels/ContingentTravelPlanQueries.cs and 2 other locations - About 50 mins to fix
          ReadModels/ContingentTravelPlanQueries.cs on lines 222..231
          ReadModels/ContingentTravelPlanQueries.cs on lines 289..298

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status