Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
ReadModels/ParticipantQueries.cs

Summary

Maintainability
C
1 day
Test Coverage

Class ParticipantQueries has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

    public class ParticipantQueries : 
        IReadModel,
        IParticipantQueries,
        ISubscribeTo<ParticipantCreated>,
        ISubscribeTo<ParticipantRenamed>,
Severity: Minor
Found in ReadModels/ParticipantQueries.cs - About 3 hrs to fix

    File ParticipantQueries.cs has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using Edument.CQRS;
using Events.Contingent;
using Events.Participant;
using Events.Tournament;
using System;
    Severity: Minor
    Found in ReadModels/ParticipantQueries.cs - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public void Handle(ParticipantAssignedToContingent e)
        {
            var contingent = Contingents.Single(x => x.Id == e.ContingentId);            
            var participant = Participants.Single(x => x.Id == e.Id);
      Severity: Major
      Found in ReadModels/ParticipantQueries.cs and 1 other location - About 1 hr to fix
      ReadModels/ReservationQueries.cs on lines 124..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  Participants.Add(new Participant
            {
                Id = e.Id,
                Name = e.Name,
                Gender = e.Gender,
      Severity: Minor
      Found in ReadModels/ParticipantQueries.cs and 1 other location - About 45 mins to fix
      ReadModels/TournamentQueries.cs on lines 286..296

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status