Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/foliogallery.php

Summary

Maintainability
F
1 wk
Test Coverage

Method make_thumb has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function make_thumb($folder,$file,$dest,$thumb_width) {

    $ext = strtolower(pathinfo($file, PATHINFO_EXTENSION));
    
    switch($ext)
Severity: Minor
Found in Web.Admin/2014/foliogallery.php - About 1 hr to fix

    Function make_thumb has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function make_thumb($folder,$file,$dest,$thumb_width) {

    $ext = strtolower(pathinfo($file, PATHINFO_EXTENSION));
    
    switch($ext)
    Severity: Minor
    Found in Web.Admin/2014/foliogallery.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function paginate_array has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function paginate_array($numPages,$urlVars,$alb,$currentPage) {
        
   $html = '';
   
   if ($numPages > 1)
    Severity: Minor
    Found in Web.Admin/2014/foliogallery.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    <!--
    folioGallery v1.3 - 2014-05-01
    (c) 2014 Harry Ghazanian - foliopages.com/php-jquery-ajax-photo-gallery-no-database
    This content is released under the http://www.opensource.org/licenses/mit-license.php MIT License.
-->
    Severity: Major
    Found in Web.Admin/2014/foliogallery.php and 1 other location - About 1 wk to fix
    Web.Admin/2015/foliogallery.php on lines 1..315

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 2013.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status