Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php

Summary

Maintainability
D
2 days
Test Coverage

Function _data_prepare has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    function _data_prepare($mode=FTP_ASCII) {
        if(!$this->_settype($mode)) return FALSE;
        $this->SendMSG("Creating data socket");
        $this->_ftp_data_sock = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
        if ($this->_ftp_data_sock < 0) {
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _data_prepare has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _data_prepare($mode=FTP_ASCII) {
        if(!$this->_settype($mode)) return FALSE;
        $this->SendMSG("Creating data socket");
        $this->_ftp_data_sock = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
        if ($this->_ftp_data_sock < 0) {
Severity: Major
Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 2 hrs to fix

    Function _data_read has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        function _data_read($mode=FTP_ASCII, $fp=NULL) {
        $NewLine=$this->_eol_code[$this->OS_local];
        if(is_resource($fp)) $out=0;
        else $out="";
        if(!$this->_passive) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _data_write has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        function _data_write($mode=FTP_ASCII, $fp=NULL) {
        $NewLine=$this->_eol_code[$this->OS_local];
        if(is_resource($fp)) $out=0;
        else $out="";
        if(!$this->_passive) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return FALSE;
    Severity: Major
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return FALSE;
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return FALSE;
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return FALSE;
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return FALSE;
            Severity: Major
            Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return FALSE;
              Severity: Major
              Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return FALSE;
                Severity: Major
                Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return FALSE;
                  Severity: Major
                  Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return TRUE;
                    Severity: Major
                    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if(!$this->_passive) {
            $this->SendMSG("Connecting to ".$this->_datahost.":".$this->_dataport);
            $this->_ftp_temp_sock=socket_accept($this->_ftp_data_sock);
            if($this->_ftp_temp_sock===FALSE) {
                $this->PushError("_data_read","socket_accept", socket_strerror(socket_last_error($this->_ftp_temp_sock)));
                      Severity: Major
                      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php and 1 other location - About 1 hr to fix
                      Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php on lines 204..212

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 109.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if(!$this->_passive) {
            $this->SendMSG("Connecting to ".$this->_datahost.":".$this->_dataport);
            $this->_ftp_temp_sock=socket_accept($this->_ftp_data_sock);
            if($this->_ftp_temp_sock===FALSE) {
                $this->PushError("_data_write","socket_accept", socket_strerror(socket_last_error($this->_ftp_temp_sock)));
                      Severity: Major
                      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php and 1 other location - About 1 hr to fix
                      Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php on lines 181..189

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 109.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if(!@socket_set_option($sock, SOL_SOCKET , SO_SNDTIMEO, array("sec"=>$this->_timeout, "usec"=>0))) {
            $this->PushError('_connect','socket set send timeout',socket_strerror(socket_last_error($sock)));
            @socket_close($sock);
            return FALSE;
        }
                      Severity: Minor
                      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php and 1 other location - About 30 mins to fix
                      Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php on lines 43..47

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if(!@socket_set_option($sock, SOL_SOCKET, SO_RCVTIMEO, array("sec"=>$this->_timeout, "usec"=>0))) {
            $this->PushError('_connect','socket set receive timeout',socket_strerror(socket_last_error($sock)));
            @socket_close($sock);
            return FALSE;
        }
                      Severity: Minor
                      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php and 1 other location - About 30 mins to fix
                      Web.Admin/2014/wordpress/wp-admin/includes/class-ftp-sockets.php on lines 48..52

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status