CaffGeek/MBACNationals

View on GitHub
Web.Admin/2014/wordpress/wp-admin/includes/class-wp-posts-list-table.php

Summary

Maintainability
F
1 wk
Test Coverage

Function inline_edit has a Cognitive Complexity of 129 (exceeds 5 allowed). Consider refactoring.
Open

    function inline_edit() {
        global $mode;

        $screen = $this->screen;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function single_row has a Cognitive Complexity of 125 (exceeds 5 allowed). Consider refactoring.
Open

    function single_row( $post, $level = 0 ) {
        global $mode;
        static $alternate;

        $global_post = get_post();

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class-wp-posts-list-table.php has 833 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Posts List Table class.
 *
 * @package WordPress

    Method inline_edit has 298 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function inline_edit() {
            global $mode;
    
            $screen = $this->screen;
    
    

      Method single_row has 228 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function single_row( $post, $level = 0 ) {
              global $mode;
              static $alternate;
      
              $global_post = get_post();

        Function _display_rows_hierarchical has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
        Open

            function _display_rows_hierarchical( $pages, $pagenum = 1, $per_page = 20 ) {
                global $wpdb;
        
                $level = 0;
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _page_rows has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
        
                if ( ! isset( $children_pages[$parent] ) )
                    return;
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_views has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            function get_views() {
                global $locked_post_status, $avail_post_stati;
        
                $post_type = $this->screen->post_type;
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _display_rows_hierarchical has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function _display_rows_hierarchical( $pages, $pagenum = 1, $per_page = 20 ) {
                global $wpdb;
        
                $level = 0;
        
        

          Method get_views has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function get_views() {
                  global $locked_post_status, $avail_post_stati;
          
                  $post_type = $this->screen->post_type;
          
          

            Method _page_rows has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
            
                    if ( ! isset( $children_pages[$parent] ) )
                        return;
            
            

              Method get_columns has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function get_columns() {
                      $post_type = $this->screen->post_type;
              
                      $posts_columns = array();
              
              

                Function get_columns has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    function get_columns() {
                        $post_type = $this->screen->post_type;
                
                        $posts_columns = array();
                
                

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method extra_tablenav has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function extra_tablenav( $which ) {
                        global $cat;
                ?>
                        <div class="alignleft actions">
                <?php

                  Method _page_rows has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
                  Severity: Minor
                  Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-posts-list-table.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if ( is_null( $parent ) )
                                                    break;
                    Severity: Major
                    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-posts-list-table.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ( !isset( $parent_name ) ) {
                                                      /** This filter is documented in wp-includes/post-template.php */
                                                      $parent_name = apply_filters( 'the_title', $parent->post_title, $parent->ID );
                                                  }
                      Severity: Major
                      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-posts-list-table.php - About 45 mins to fix

                        Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            function __construct( $args = array() ) {
                                global $post_type_object, $wpdb;
                        
                                parent::__construct( array(
                                    'plural' => 'posts',
                        Severity: Minor
                        Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-posts-list-table.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if ( $can_edit_post && 'trash' != $post->post_status ) {
                                            $actions['edit'] = '<a href="' . get_edit_post_link( $post->ID, true ) . '" title="' . esc_attr( __( 'Edit this item' ) ) . '">' . __( 'Edit' ) . '</a>';
                                            $actions['inline hide-if-no-js'] = '<a href="#" class="editinline" title="' . esc_attr( __( 'Edit this item inline' ) ) . '">' . __( 'Quick&nbsp;Edit' ) . '</a>';
                                        }
                        Web.Admin/2014/wordpress/wp-admin/includes/template.php on lines 1447..1450

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 120.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status