Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php

Summary

Maintainability
F
3 days
Test Coverage

File class-wp-upgrader-skins.php has 496 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * The User Interface "Skins" for the WordPress File Upgrader
 *
 * @package WordPress
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 7 hrs to fix

    Function after has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        function after() {

        $plugin_file = $this->upgrader->plugin_info();

        $install_actions = array();
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function after has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        function after() {
        $this->decrement_update_count( 'theme' );

        $update_actions = array();
        if ( ! empty( $this->upgrader->result['destination_name'] ) && $theme_info = $this->upgrader->theme_info() ) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method after has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function after() {
        if ( empty($this->upgrader->result['destination_name']) )
            return;

        $theme_info = $this->upgrader->theme_info();
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

      Method after has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function after() {
        $this->decrement_update_count( 'theme' );

        $update_actions = array();
        if ( ! empty( $this->upgrader->result['destination_name'] ) && $theme_info = $this->upgrader->theme_info() ) {
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

        Function error has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            function error($errors) {
        if ( ! $this->done_header )
            $this->header();
        if ( is_string($errors) ) {
            $this->feedback($errors);
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function feedback has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            function feedback( $data ) {
        if ( is_wp_error( $data ) )
            $string = $data->get_error_message();
        else if ( is_array( $data ) )
            return;
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method feedback has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function feedback( $data ) {
        if ( is_wp_error( $data ) )
            $string = $data->get_error_message();
        else if ( is_array( $data ) )
            return;
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 1 hr to fix

          Function after has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              function after($title = '') {
        echo '</p></div>';
        if ( $this->error || ! $this->result ) {
            if ( $this->error )
                echo '<div class="error"><p>' . sprintf($this->upgrader->strings['skin_update_failed_error'], $title, $this->error) . '</p></div>';
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function error has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              function error($error) {
        if ( is_string($error) && isset( $this->upgrader->strings[$error] ) )
            $this->error = $this->upgrader->strings[$error];

        if ( is_wp_error($error) ) {
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function after has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              function after() {
        if ( empty($this->upgrader->result['destination_name']) )
            return;

        $theme_info = $this->upgrader->theme_info();
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function feedback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              function feedback($string) {
        if ( isset( $this->upgrader->strings[$string] ) )
            $string = $this->upgrader->strings[$string];

        if ( strpos($string, '%') !== false ) {
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  else if ( $this->type == 'web' )
            $install_actions['plugins_page'] = '<a href="' . self_admin_url('plugin-install.php') . '" title="' . esc_attr__('Return to Plugin Installer') . '" target="_parent">' . __('Return to Plugin Installer') . '</a>';
        else
            $install_actions['plugins_page'] = '<a href="' . self_admin_url('plugins.php') . '" title="' . esc_attr__('Return to Plugins page') . '" target="_parent">' . __('Return to Plugins page') . '</a>';
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 2 other locations - About 2 hrs to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 982..985
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 1050..1053

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function __construct($args = array()) {
        $defaults = array( 'type' => 'web', 'url' => '', 'theme' => '', 'nonce' => '', 'title' => '' );
        $args = wp_parse_args($args, $defaults);

        $this->type = $args['type'];
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 3 other locations - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 407..415
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 959..967
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 1014..1022

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              function __construct($args = array()) {
        $defaults = array( 'type' => 'web', 'url' => '', 'plugin' => '', 'nonce' => '', 'title' => '' );
        $args = wp_parse_args($args, $defaults);

        $this->type = $args['type'];
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 3 other locations - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 482..490
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 959..967
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 1014..1022

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $update_actions =  array(
            'plugins_page' => '<a href="' . self_admin_url('plugins.php') . '" title="' . esc_attr__('Go to plugins page') . '" target="_parent">' . __('Return to Plugins page') . '</a>',
            'updates_page' => '<a href="' . self_admin_url('update-core.php') . '" title="' . esc_attr__('Go to WordPress Updates page') . '" target="_parent">' . __('Return to WordPress Updates') . '</a>'
        );
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 1 other location - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 374..377

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $update_actions =  array(
            'themes_page' => '<a href="' . self_admin_url('themes.php') . '" title="' . esc_attr__('Go to themes page') . '" target="_parent">' . __('Return to Themes page') . '</a>',
            'updates_page' => '<a href="' . self_admin_url('update-core.php') . '" title="' . esc_attr__('Go to WordPress Updates page') . '" target="_parent">' . __('Return to WordPress Updates') . '</a>'
        );
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 1 other location - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 329..332

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( strpos($string, '%') !== false ) {
            $args = func_get_args();
            $args = array_splice($args, 1);
            if ( $args ) {
                $args = array_map( 'strip_tags', $args );
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 1 other location - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 201..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( strpos($string, '%') !== false ) {
            $args = func_get_args();
            $args = array_splice($args, 1);
            if ( $args ) {
                $args = array_map( 'strip_tags', $args );
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 1 other location - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php on lines 79..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function request_filesystem_credentials($error = false) {
        $url = $this->options['url'];
        $context = $this->options['context'];
        if ( !empty($this->options['nonce']) )
            $url = wp_nonce_url($url, $this->options['nonce']);
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader-skins.php and 1 other location - About 50 mins to fix
          Web.Admin/2014/wordpress/wp-admin/includes/class-wp-upgrader.php on lines 828..834

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status