CaffGeek/MBACNationals

View on GitHub
Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php

Summary

Maintainability
D
2 days
Test Coverage

File deprecated.php has 437 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Deprecated admin functions from past WordPress versions. You shouldn't use these
 * functions and look for the alternatives instead. The functions will be removed
 * in a later version.
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 6 hrs to fix

    Function wp_dropdown_cats has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function wp_dropdown_cats( $currentcat = 0, $currentparent = 0, $parent = 0, $level = 0, $categories = 0 ) {
        _deprecated_function( __FUNCTION__, '3.0', 'wp_dropdown_categories()' );
        if (!$categories )
            $categories = get_categories( array('hide_empty' => 0) );
    
    
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function do_paging has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        function do_paging() {
            if ( $this->total_users_for_query > $this->users_per_page ) { // have to page the results
                $args = array();
                if( ! empty($this->search_term) )
                    $args['usersearch'] = urlencode($this->search_term);
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_editable_user_ids has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function get_editable_user_ids( $user_id, $exclude_zeros = true, $post_type = 'post' ) {
        _deprecated_function( __FUNCTION__, '3.1', 'get_users()' );
    
        global $wpdb;
    
    
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function prepare_query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        function prepare_query() {
            global $wpdb;
            $this->first_user = ($this->page - 1) * $this->users_per_page;
    
            $this->query_limit = $wpdb->prepare(" LIMIT %d, %d", $this->first_user, $this->users_per_page);
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wp_dropdown_cats has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function wp_dropdown_cats( $currentcat = 0, $currentparent = 0, $parent = 0, $level = 0, $categories = 0 ) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          function do_paging() {
              if ( $this->total_users_for_query > $this->users_per_page ) { // have to page the results
                  $args = array();
                  if( ! empty($this->search_term) )
                      $args['usersearch'] = urlencode($this->search_term);
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php and 1 other location - About 1 day to fix
      Web.Admin/2014/wordpress/wp-admin/includes/user.php on lines 708..732

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 257.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if ( $categories ) {
              foreach ( $categories as $category ) {
                  if ( $currentcat != $category->term_id && $parent == $category->parent) {
                      $pad = str_repeat( '&#8211; ', $level );
                      $category->name = esc_html( $category->name );
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php and 1 other location - About 2 hrs to fix
      Web.Admin/2014/wordpress/wp-admin/includes/template.php on lines 2408..2422

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status