Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php

Summary

Maintainability
F
4 days
Test Coverage

Function install_plugin_information has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

function install_plugin_information() {
    global $tab;

    $api = plugins_api('plugin_information', array('slug' => stripslashes( $_REQUEST['plugin'] ) ));
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method install_plugin_information has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function install_plugin_information() {
    global $tab;

    $api = plugins_api('plugin_information', array('slug' => stripslashes( $_REQUEST['plugin'] ) ));
Severity: Major
Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 5 hrs to fix

    File plugin-install.php has 390 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * WordPress Plugin Install Administration API
 *
 * @package WordPress
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 5 hrs to fix

      Method display_plugins_table has 105 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function display_plugins_table($plugins, $page = 1, $totalpages = 1){
    $type = isset($_REQUEST['type']) ? stripslashes( $_REQUEST['type'] ) : '';
    $term = isset($_REQUEST['s']) ? stripslashes( $_REQUEST['s'] ) : '';

    $plugins_allowedtags = array('a' => array('href' => array(),'title' => array(), 'target' => array()),
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 4 hrs to fix

        Function display_plugins_table has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

        function display_plugins_table($plugins, $page = 1, $totalpages = 1){
    $type = isset($_REQUEST['type']) ? stripslashes( $_REQUEST['type'] ) : '';
    $term = isset($_REQUEST['s']) ? stripslashes( $_REQUEST['s'] ) : '';

    $plugins_allowedtags = array('a' => array('href' => array(),'title' => array(), 'target' => array()),
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function plugins_api has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function plugins_api($action, $args = null) {

    if( is_array($args) )
        $args = (object)$args;
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $plugins_allowedtags = array('a' => array('href' => array(), 'title' => array(), 'target' => array()),
                                'abbr' => array('title' => array()), 'acronym' => array('title' => array()),
                                'code' => array(), 'pre' => array(), 'em' => array(), 'strong' => array(),
                                'div' => array(), 'p' => array(), 'ul' => array(), 'ol' => array(), 'li' => array(),
                                'h1' => array(), 'h2' => array(), 'h3' => array(), 'h4' => array(), 'h5' => array(), 'h6' => array(),
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php and 1 other location - About 4 hrs to fix
        Web.Admin/2014/wordpress/wp-admin/includes/theme-install.php on lines 9..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 170.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ( ! $res ) {
        $request = wp_remote_post('http://api.wordpress.org/plugins/info/1.0/', array( 'body' => array('action' => $action, 'request' => serialize($args))) );
        if ( is_wp_error($request) ) {
            $res = new WP_Error('plugins_api_failed', __('An Unexpected HTTP Error occurred during the API request.</p> <p><a href="?" onclick="document.location.reload(); return false;">Try again</a>'), $request->get_error_message() );
        } else {
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php and 1 other location - About 3 hrs to fix
        Web.Admin/2014/wordpress/wp-admin/includes/theme-install.php on lines 54..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 143.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            $plugins_allowedtags = array('a' => array('href' => array(),'title' => array(), 'target' => array()),
                                'abbr' => array('title' => array()),'acronym' => array('title' => array()),
                                'code' => array(), 'pre' => array(), 'em' => array(),'strong' => array(),
                                'ul' => array(), 'ol' => array(), 'li' => array(), 'p' => array(), 'br' => array());
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php and 1 other location - About 1 hr to fix
        Web.Admin/2014/wordpress/wp-admin/includes/class-wp-plugin-install-list-table.php on lines 193..198

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function install_featured($page = 1) {
    $args = array('browse' => 'featured', 'page' => $page);
    $api = plugins_api('query_plugins', $args);
    if ( is_wp_error($api) )
        wp_die($api);
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php and 1 other location - About 50 mins to fix
        Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php on lines 231..237

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function install_new($page = 1) {
    $args = array('browse' => 'new', 'page' => $page);
    $api = plugins_api('query_plugins', $args);
    if ( is_wp_error($api) )
        wp_die($api);
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php and 1 other location - About 50 mins to fix
        Web.Admin/2014/wordpress/wp-admin/includes/plugin-install.php on lines 181..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status