CaffGeek/MBACNationals

View on GitHub
Web.Admin/2014/wordpress/wp-admin/includes/revision.php

Summary

Maintainability
D
1 day
Test Coverage

Function wp_prepare_revisions_for_js has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

function wp_prepare_revisions_for_js( $post, $selected_revision_id, $from = null ) {
    $post = get_post( $post );
    $revisions = $authors = array();
    $now_gmt = time();

Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wp_prepare_revisions_for_js has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function wp_prepare_revisions_for_js( $post, $selected_revision_id, $from = null ) {
    $post = get_post( $post );
    $revisions = $authors = array();
    $now_gmt = time();

Severity: Major
Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 3 hrs to fix

    Function wp_get_revision_ui_diff has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function wp_get_revision_ui_diff( $post, $compare_from, $compare_to ) {
        if ( ! $post = get_post( $post ) )
            return false;
    
        if ( $compare_from ) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wp_get_revision_ui_diff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function wp_get_revision_ui_diff( $post, $compare_from, $compare_to ) {
        if ( ! $post = get_post( $post ) )
            return false;
    
        if ( $compare_from ) {
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return $return;
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/revision.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status