Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-admin/includes/theme.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method delete_theme has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function delete_theme($template) {
    global $wp_filesystem;

    if ( empty($template) )
        return false;
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 1 hr to fix

    Function get_page_templates has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function get_page_templates() {
    $themes = get_themes();
    $theme = get_current_theme();
    $templates = $themes[$theme]['Template Files'];
    $page_templates = array();
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function delete_theme has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function delete_theme($template) {
    global $wp_filesystem;

    if ( empty($template) )
        return false;
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return new WP_Error('fs_error', __('Filesystem error'), $wp_filesystem->errors);
    Severity: Major
    Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return true;
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return new WP_Error('fs_no_themes_dir', __('Unable to locate WordPress theme directory.'));
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return new WP_Error('could_not_remove_theme', sprintf(__('Could not fully remove the theme %s'), $template) );
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if ( ! WP_Filesystem($credentials) ) {
        request_filesystem_credentials($url, '', true); // Failed to connect, Error and request again
        $data = ob_get_contents();
        ob_end_clean();
        if( ! empty($data) ){
            Severity: Minor
            Found in Web.Admin/2014/wordpress/wp-admin/includes/theme.php and 1 other location - About 30 mins to fix
            Web.Admin/2014/wordpress/wp-admin/includes/plugin.php on lines 422..433

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status