Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-admin/includes/user.php

Summary

Maintainability
F
3 days
Test Coverage

Function edit_user has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

function edit_user( $user_id = 0 ) {
    global $current_user, $wp_roles, $wpdb;
    if ( $user_id != 0 ) {
        $update = true;
        $user->ID = (int) $user_id;
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File user.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * WordPress user administration API.
 *
 * @package WordPress
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 4 hrs to fix

    Method edit_user has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function edit_user( $user_id = 0 ) {
    global $current_user, $wp_roles, $wpdb;
    if ( $user_id != 0 ) {
        $update = true;
        $user->ID = (int) $user_id;
    Severity: Major
    Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 3 hrs to fix

      Function add_user has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function add_user() {
    if ( func_num_args() ) { // The hackiest hack that ever did hack
        global $current_user, $wp_roles;
        $user_id = (int) func_get_arg( 0 );
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function wp_delete_user has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function wp_delete_user($id, $reassign = 'novalue') {
    global $wpdb;

    $id = (int) $id;
    $user = new WP_User($id);
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function do_paging has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          function do_paging() {
        if ( $this->total_users_for_query > $this->users_per_page ) { // have to page the results
            $args = array();
            if( ! empty($this->search_term) )
                $args['usersearch'] = urlencode($this->search_term);
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method wp_delete_user has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function wp_delete_user($id, $reassign = 'novalue') {
    global $wpdb;

    $id = (int) $id;
    $user = new WP_User($id);
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 1 hr to fix

        Function prepare_query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            function prepare_query() {
        global $wpdb;
        $this->first_user = ($this->page - 1) * $this->users_per_page;
        $this->query_limit = $wpdb->prepare(" LIMIT %d, %d", $this->first_user, $this->users_per_page);
        $this->query_sort = ' ORDER BY user_login';
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_editable_user_ids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function get_editable_user_ids( $user_id, $exclude_zeros = true, $post_type = 'post' ) {
    global $wpdb;

    $user = new WP_User( $user_id );
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            function do_paging() {
        if ( $this->total_users_for_query > $this->users_per_page ) { // have to page the results
            $args = array();
            if( ! empty($this->search_term) )
                $args['usersearch'] = urlencode($this->search_term);
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-admin/includes/user.php and 1 other location - About 1 day to fix
        Web.Admin/2014/wordpress/wp-admin/includes/deprecated.php on lines 578..602

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 257.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status