CaffGeek/MBACNationals

View on GitHub
Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php

Summary

Maintainability
F
3 wks
Test Coverage

File module.audio-video.quicktime.php has 1830 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/////////////////////////////////////////////////////////////////
/// getID3() by James Heinrich <info@getid3.org>               //
//  available at http://getid3.sourceforge.net                 //
//            or http://www.getid3.org                         //

    Method QuicktimeParseAtom has 983 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset, &$atomHierarchy, $ParseAllPossibleAtoms) {
            // http://developer.apple.com/techpubs/quicktime/qtdevdocs/APIREF/INDEX/atomalphaindex.htm
    
            $info = &$this->getid3->info;
    
    

      Function QuicktimeParseAtom has a Cognitive Complexity of 216 (exceeds 5 allowed). Consider refactoring.
      Open

          public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset, &$atomHierarchy, $ParseAllPossibleAtoms) {
              // http://developer.apple.com/techpubs/quicktime/qtdevdocs/APIREF/INDEX/atomalphaindex.htm
      
              $info = &$this->getid3->info;
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Analyze has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
      Open

          public function Analyze() {
              $info = &$this->getid3->info;
      
              $info['fileformat'] = 'quicktime';
              $info['quicktime']['hinting']    = false;

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method QuicktimeParseNikonNCTG has 150 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function QuicktimeParseNikonNCTG($atom_data) {
              // http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Nikon.html#NCTG
              // Nikon-specific QuickTime tags found in the NCDT atom of MOV videos from some Nikon cameras such as the Coolpix S8000 and D5100
              // Data is stored as records of:
              // * 4 bytes record type

        Function QuicktimeParseNikonNCTG has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
        Open

            public function QuicktimeParseNikonNCTG($atom_data) {
                // http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Nikon.html#NCTG
                // Nikon-specific QuickTime tags found in the NCDT atom of MOV videos from some Nikon cameras such as the Coolpix S8000 and D5100
                // Data is stored as records of:
                // * 4 bytes record type

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method QuicktimeLanguageLookup has 122 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function QuicktimeLanguageLookup($languageid) {
                // http://developer.apple.com/library/mac/#documentation/QuickTime/QTFF/QTFFChap4/qtff4.html#//apple_ref/doc/uid/TP40000939-CH206-34353
                static $QuicktimeLanguageLookup = array();
                if (empty($QuicktimeLanguageLookup)) {
                    $QuicktimeLanguageLookup[0]     = 'English';

          Method Analyze has 112 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function Analyze() {
                  $info = &$this->getid3->info;
          
                  $info['fileformat'] = 'quicktime';
                  $info['quicktime']['hinting']    = false;

            Method CopyToAppropriateCommentsSection has 91 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function CopyToAppropriateCommentsSection($keyname, $data, $boxname='') {
                    static $handyatomtranslatorarray = array();
                    if (empty($handyatomtranslatorarray)) {
                        $handyatomtranslatorarray['©cpy'] = 'copyright';
                        $handyatomtranslatorarray['©day'] = 'creation_date';    // iTunes 4.0

              Method QuicktimeIODSvideoProfileName has 68 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function QuicktimeIODSvideoProfileName($video_profile_id) {
                      static $QuicktimeIODSvideoProfileNameLookup = array();
                      if (empty($QuicktimeIODSvideoProfileNameLookup)) {
                          $QuicktimeIODSvideoProfileNameLookup = array(
                              0x00 => 'Reserved (0x00) Profile',

                Function CopyToAppropriateCommentsSection has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function CopyToAppropriateCommentsSection($keyname, $data, $boxname='') {
                        static $handyatomtranslatorarray = array();
                        if (empty($handyatomtranslatorarray)) {
                            $handyatomtranslatorarray['©cpy'] = 'copyright';
                            $handyatomtranslatorarray['©day'] = 'creation_date';    // iTunes 4.0

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method QuicktimeVideoCodecLookup has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function QuicktimeVideoCodecLookup($codecid) {
                        static $QuicktimeVideoCodecLookup = array();
                        if (empty($QuicktimeVideoCodecLookup)) {
                            $QuicktimeVideoCodecLookup['.SGI'] = 'SGI';
                            $QuicktimeVideoCodecLookup['3IV1'] = '3ivx MPEG-4 v1';

                  Method QuicktimeIODSaudioProfileName has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function QuicktimeIODSaudioProfileName($audio_profile_id) {
                          static $QuicktimeIODSaudioProfileNameLookup = array();
                          if (empty($QuicktimeIODSaudioProfileNameLookup)) {
                              $QuicktimeIODSaudioProfileNameLookup = array(
                                  0x00 => 'ISO Reserved (0x00)',

                    Method QuicktimeAudioCodecLookup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function QuicktimeAudioCodecLookup($codecid) {
                            static $QuicktimeAudioCodecLookup = array();
                            if (empty($QuicktimeAudioCodecLookup)) {
                                $QuicktimeAudioCodecLookup['.mp3']          = 'Fraunhofer MPEG Layer-III alias';
                                $QuicktimeAudioCodecLookup['aac ']          = 'ISO/IEC 14496-3 AAC';

                      Method QuicktimeStoreFrontCodeLookup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function QuicktimeStoreFrontCodeLookup($sfid) {
                              static $QuicktimeStoreFrontCodeLookup = array();
                              if (empty($QuicktimeStoreFrontCodeLookup)) {
                                  $QuicktimeStoreFrontCodeLookup[143460] = 'Australia';
                                  $QuicktimeStoreFrontCodeLookup[143445] = 'Austria';

                        Avoid deeply nested control flow statements.
                        Open

                                                                    switch ($atomname) {
                                                                        case 'cpil':
                                                                        case 'pcst':
                                                                        case 'pgap':
                                                                            $atom_structure['data'] = getid3_lib::BigEndian2Int(substr($boxdata, 8, 1));

                          Avoid deeply nested control flow statements.
                          Open

                                                      if (!empty($getid3_temp->info['warning'])) {
                                                          foreach ($getid3_temp->info['warning'] as $value) {
                                                              $info['warning'][] = $value;
                                                          }
                                                      }

                            Avoid deeply nested control flow statements.
                            Open

                                                                switch ($atom_structure['sample_description_table'][$i]['data_format']) {
                                                                    case 'raw ': // PCM
                                                                    case 'alac': // Apple Lossless Audio Codec
                                                                        $info['audio']['lossless'] = true;
                                                                        break;

                              Method QuicktimeParseAtom has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset, &$atomHierarchy, $ParseAllPossibleAtoms) {

                                Avoid deeply nested control flow statements.
                                Open

                                                                    if ($atom_structure['sample_description_table'][$i]['video_pixel_color_name'] != 'invalid') {
                                                                        $info['quicktime']['video']['codec_fourcc']        = $atom_structure['sample_description_table'][$i]['data_format'];
                                                                        $info['quicktime']['video']['codec_fourcc_lookup'] = $this->QuicktimeVideoCodecLookup($atom_structure['sample_description_table'][$i]['data_format']);
                                                                        $info['quicktime']['video']['codec']               = (($atom_structure['sample_description_table'][$i]['video_encoder_name_len'] > 0) ? $atom_structure['sample_description_table'][$i]['video_encoder_name'] : $atom_structure['sample_description_table'][$i]['data_format']);
                                                                        $info['quicktime']['video']['color_depth']         = $atom_structure['sample_description_table'][$i]['video_pixel_color_depth'];

                                  Avoid deeply nested control flow statements.
                                  Open

                                                              if (!empty($getid3_temp->info['mpeg'])) {
                                                                  $info['mpeg'] = $getid3_temp->info['mpeg'];
                                                                  if (isset($info['mpeg']['audio'])) {
                                                                      $info['audio']['dataformat']   = 'mp3';
                                                                      $info['audio']['codec']        = (!empty($info['mpeg']['audio']['encoder']) ? $info['mpeg']['audio']['encoder'] : (!empty($info['mpeg']['audio']['codec']) ? $info['mpeg']['audio']['codec'] : (!empty($info['mpeg']['audio']['LAME']) ? 'LAME' :'mp3')));

                                    Avoid deeply nested control flow statements.
                                    Open

                                    if (!empty($atom_structure['sample_description_table'][$i]['width']) && !empty($atom_structure['sample_description_table'][$i]['height'])) {
                                        // assume that values stored here are more important than values stored in [tkhd] atom
                                        $info['video']['resolution_x'] = $atom_structure['sample_description_table'][$i]['width'];
                                        $info['video']['resolution_y'] = $atom_structure['sample_description_table'][$i]['height'];
                                        $info['quicktime']['video']['resolution_x'] = $info['video']['resolution_x'];

                                      Similar blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                                  case 'stco': // Sample Table Chunk Offset atom
                                                      if ($ParseAllPossibleAtoms) {
                                                          $atom_structure['version']        = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                                          $atom_structure['flags_raw']      = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                                          $atom_structure['number_entries'] = getid3_lib::BigEndian2Int(substr($atom_data,  4, 4));
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 883..894
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 946..957

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 174.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                                  case 'co64': // Chunk Offset 64-bit (version of "stco" that supports > 2GB files)
                                                      if ($ParseAllPossibleAtoms) {
                                                          $atom_structure['version']        = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                                          $atom_structure['flags_raw']      = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                                          $atom_structure['number_entries'] = getid3_lib::BigEndian2Int(substr($atom_data,  4, 4));
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 883..894
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 932..943

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 174.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                                  case 'stss': // Sample Table Sync Sample (key frames) atom
                                                      if ($ParseAllPossibleAtoms) {
                                                          $atom_structure['version']        = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                                          $atom_structure['flags_raw']      = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                                          $atom_structure['number_entries'] = getid3_lib::BigEndian2Int(substr($atom_data,  4, 4));
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 932..943
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 946..957

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 174.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  case 'rmla': // Reference Movie Language Atom
                                                      $atom_structure['version']   = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                                      $atom_structure['flags_raw'] = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                                      $atom_structure['track_id']  = getid3_lib::BigEndian2Int(substr($atom_data,  4, 2));
                                                      break;
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 564..568

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 98.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  case 'rmcs': // Reference Movie Cpu Speed atom
                                                      $atom_structure['version']          = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
                                                      $atom_structure['flags_raw']        = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3)); // hardcoded: 0x0000
                                                      $atom_structure['cpu_speed_rating'] = getid3_lib::BigEndian2Int(substr($atom_data,  4, 2));
                                                      break;
                                      Web.Admin/2014/wordpress/wp-includes/ID3/module.audio-video.quicktime.php on lines 614..618

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 98.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status