Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php

Summary

Maintainability
D
3 days
Test Coverage

Function parseMETAdata has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function parseMETAdata() {
        $info = &$this->getid3->info;
        do {
            $BlockOffset   = $this->ftell();
            $BlockHeader   = $this->fread(4);
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseMETAdata has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parseMETAdata() {
        $info = &$this->getid3->info;
        do {
            $BlockOffset   = $this->ftell();
            $BlockHeader   = $this->fread(4);
Severity: Major
Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 4 hrs to fix

    File module.audio.flac.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/////////////////////////////////////////////////////////////////
/// getID3() by James Heinrich <info@getid3.org>               //
//  available at http://getid3.sourceforge.net                 //
//            or http://www.getid3.org                         //
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 4 hrs to fix

      Method parseCUESHEET has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function parseCUESHEET($BlockData) {
        $info = &$this->getid3->info;
        $offset = 0;
        $info['flac']['CUESHEET']['media_catalog_number'] =                              trim(substr($BlockData, $offset, 128), "\0");
        $offset += 128;
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 1 hr to fix

        Method parseSTREAMINFO has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function parseSTREAMINFO($BlockData) {
        $info = &$this->getid3->info;

        $info['flac']['STREAMINFO'] = array();
        $streaminfo = &$info['flac']['STREAMINFO'];
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 1 hr to fix

          Method applicationIDLookup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function applicationIDLookup($applicationid) {
        // http://flac.sourceforge.net/id.html
        static $lookup = array(
            0x41544348 => 'FlacFile',                                                                           // "ATCH"
            0x42534F4C => 'beSolo',                                                                             // "BSOL"
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 1 hr to fix

            Function parseSTREAMINFO has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function parseSTREAMINFO($BlockData) {
        $info = &$this->getid3->info;

        $info['flac']['STREAMINFO'] = array();
        $streaminfo = &$info['flac']['STREAMINFO'];
            Severity: Minor
            Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return $this->error('Corrupt FLAC file: uncompressed_audio_bytes == zero');
            Severity: Major
            Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return false;
              Severity: Major
              Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return false;
                Severity: Major
                Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true;
                  Severity: Major
                  Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            static $lookup = array (
             0 => 'Other',
             1 => '32x32 pixels \'file icon\' (PNG only)',
             2 => 'Other file icon',
             3 => 'Cover (front)',
                    Severity: Major
                    Found in Web.Admin/2014/wordpress/wp-includes/ID3/module.audio.flac.php and 1 other location - About 1 hr to fix
                    Web.Admin/2014/wordpress/wp-includes/ID3/module.tag.id3v2.php on lines 2902..2924

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 113.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status