Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function shortcode has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    function shortcode( $attr, $url = '' ) {
        $post = get_post();

        if ( empty( $url ) )
            return '';
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shortcode has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function shortcode( $attr, $url = '' ) {
        $post = get_post();

        if ( empty( $url ) )
            return '';
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $this->maybe_make_link( $url );
    Severity: Major
    Found in Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return apply_filters( 'embed_oembed_html', $html, $url, $attr, $post_ID );
      Severity: Major
      Found in Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ( $this->handlers as $priority => $handlers ) {
            foreach ( $handlers as $id => $handler ) {
                if ( preg_match( $handler['regex'], $url, $matches ) && is_callable( $handler['callback'] ) ) {
                    if ( false !== $return = call_user_func( $handler['callback'], $matches, $attr, $url, $rawattr ) )
                        /**
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-includes/class-wp-embed.php and 1 other location - About 1 hr to fix
        Web.Admin/2014/wordpress/wp-includes/media.php on lines 1072..1079

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status