CaffGeek/MBACNationals

View on GitHub
Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php

Summary

Maintainability
F
1 wk
Test Coverage

Function paged_walk has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    function paged_walk( $elements, $max_depth, $page_num, $per_page ) {

        /* sanity check */
        if ( empty($elements) || $max_depth < -1 )
            return '';
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function walk has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    function walk( $elements, $max_depth) {

        $args = array_slice(func_get_args(), 2);
        $output = '';

Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method paged_walk has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function paged_walk( $elements, $max_depth, $page_num, $per_page ) {

        /* sanity check */
        if ( empty($elements) || $max_depth < -1 )
            return '';
Severity: Major
Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 3 hrs to fix

    Method walk has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function walk( $elements, $max_depth) {
    
            $args = array_slice(func_get_args(), 2);
            $output = '';
    
    
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 1 hr to fix

      Function display_element has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          function display_element( $element, &$children_elements, $max_depth, $depth, $args, &$output ) {
      
              if ( !$element )
                  return;
      
      
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method display_element has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function display_element( $element, &$children_elements, $max_depth, $depth, $args, &$output ) {
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 45 mins to fix

        Method start_el has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function start_el( &$output, $object, $depth = 0, $args = array(), $current_object_id = 0 ) {}
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 35 mins to fix

          Function unset_children has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              function unset_children( $e, &$children_elements ){
          
                  if ( !$e || !$children_elements )
                      return;
          
          
          Severity: Minor
          Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function paged_walk( $elements, $max_depth, $page_num, $per_page ) {
          
                  /* sanity check */
                  if ( empty($elements) || $max_depth < -1 )
                      return '';
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php and 1 other location - About 4 days to fix
          Web.Admin/2014/wordpress/wp-includes/classes.php on lines 972..1078

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 771.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function walk( $elements, $max_depth) {
          
                  $args = array_slice(func_get_args(), 2);
                  $output = '';
          
          
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php and 1 other location - About 2 days to fix
          Web.Admin/2014/wordpress/wp-includes/classes.php on lines 886..957

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 413.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( ($max_depth == 0 || $max_depth > $depth+1 ) && isset( $children_elements[$id]) ) {
          
                      foreach( $children_elements[ $id ] as $child ){
          
                          if ( !isset($newlevel) ) {
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php and 1 other location - About 2 hrs to fix
          Web.Admin/2014/wordpress/wp-includes/classes.php on lines 846..859

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 139.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function unset_children( $e, &$children_elements ){
          
                  if ( !$e || !$children_elements )
                      return;
          
          
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-includes/class-wp-walker.php and 1 other location - About 1 hr to fix
          Web.Admin/2014/wordpress/wp-includes/classes.php on lines 1093..1108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status