Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-includes/revision.php

Summary

Maintainability
F
3 days
Test Coverage

Function wp_save_post_revision has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

function wp_save_post_revision( $post_id ) {
    if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE )
        return;

    if ( ! $post = get_post( $post_id ) )
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File revision.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Post revision functions.
 *
 * @package WordPress
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 2 hrs to fix

    Method wp_save_post_revision has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function wp_save_post_revision( $post_id ) {
    if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE )
        return;

    if ( ! $post = get_post( $post_id ) )
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 1 hr to fix

      Function _wp_upgrade_revisions_of_post has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function _wp_upgrade_revisions_of_post( $post, $revisions ) {
    global $wpdb;

    // Add post option exclusively
    $lock = "revision-upgrade-{$post->ID}";
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _wp_upgrade_revisions_of_post has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _wp_upgrade_revisions_of_post( $post, $revisions ) {
    global $wpdb;

    // Add post option exclusively
    $lock = "revision-upgrade-{$post->ID}";
      Severity: Minor
      Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 1 hr to fix

        Function wp_get_post_autosave has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function wp_get_post_autosave( $post_id, $user_id = 0 ) {
    $revisions = wp_get_post_revisions( $post_id, array( 'check_enabled' => false ) );

    foreach ( $revisions as $revision ) {
        if ( false !== strpos( $revision->post_name, "{$post_id}-autosave" ) ) {
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _wp_put_post_revision has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function _wp_put_post_revision( $post = null, $autosave = false ) {
    if ( is_object($post) )
        $post = get_object_vars( $post );
    elseif ( !is_array($post) )
        $post = get_post($post, ARRAY_A);
        Severity: Minor
        Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return $revision;
        Severity: Major
        Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $_revision;
          Severity: Major
          Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return;
            Severity: Major
            Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $return;
              Severity: Major
              Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $return;
                Severity: Major
                Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return $return;
                  Severity: Major
                  Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return;
                    Severity: Major
                    Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 30 mins to fix

                      Function wp_restore_post_revision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function wp_restore_post_revision( $revision_id, $fields = null ) {
    if ( !$revision = wp_get_post_revision( $revision_id, ARRAY_A ) )
        return $revision;

    if ( !is_array( $fields ) )
                      Severity: Minor
                      Found in Web.Admin/2014/wordpress/wp-includes/revision.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      function _wp_post_revision_fields( $post = null, $autosave = false ) {
    static $fields = false;

    if ( !$fields ) {
        // Allow these to be versioned
                      Severity: Major
                      Found in Web.Admin/2014/wordpress/wp-includes/revision.php and 1 other location - About 1 day to fix
                      Web.Admin/2014/wordpress/wp-includes/post.php on lines 3658..3692

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 336.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                      function _show_post_preview() {

    if ( isset($_GET['preview_id']) && isset($_GET['preview_nonce']) ) {
        $id = (int) $_GET['preview_id'];
                      Severity: Minor
                      Found in Web.Admin/2014/wordpress/wp-includes/revision.php and 1 other location - About 55 mins to fix
                      Web.Admin/2014/wordpress/wp-includes/post.php on lines 4026..4036

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 98.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status