Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Web.Admin/2014/wordpress/wp-includes/wp-diff.php

Summary

Maintainability
C
1 day
Test Coverage

Function interleave_changed_lines has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    function interleave_changed_lines( $orig, $final ) {

        // Contains all pairwise string comparisons.  Keys are such that this need only be a one dimensional array.
        $matches = array();
        foreach ( array_keys($orig) as $o ) {
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/wp-diff.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _changed has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    function _changed( $orig, $final ) {
        $r = '';

        // Does the aforementioned additional processing
        // *_matches tell what rows are "the same" in orig and final.  Those pairs will be diffed to get word changes
Severity: Minor
Found in Web.Admin/2014/wordpress/wp-includes/wp-diff.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method interleave_changed_lines has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function interleave_changed_lines( $orig, $final ) {

        // Contains all pairwise string comparisons.  Keys are such that this need only be a one dimensional array.
        $matches = array();
        foreach ( array_keys($orig) as $o ) {
Severity: Major
Found in Web.Admin/2014/wordpress/wp-includes/wp-diff.php - About 2 hrs to fix

    Method _changed has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function _changed( $orig, $final ) {
        $r = '';

        // Does the aforementioned additional processing
        // *_matches tell what rows are "the same" in orig and final.  Those pairs will be diffed to get word changes
    Severity: Minor
    Found in Web.Admin/2014/wordpress/wp-includes/wp-diff.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status