Sign upLogin

CaffGeek/MBACNationals

View on GitHub
Star
Website/src/app/services/tournaments.service.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    2019: {
      Theme: 'theme-2019',
      Contingents: [ ...this.provinces ],
      Welcome: `Welcome to the online home of the 2019 Master Bowlers Association of Canada Nationals,
        taking place June 28 - July 4, 2019 in Gatineau, Quebec.`,
Severity: Major
Found in Website/src/app/services/tournaments.service.ts and 1 other location - About 4 hrs to fix
Website/src/app/services/tournaments.service.ts on lines 84..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    2017: {
      Theme: 'theme-2017',
      Contingents: [ ...this.provinces ],
      Welcome: `Welcome to the online home of the 2017 Master Bowlers Association of Canada Nationals,
        taking place June 29 - July 3, 2017 in Regina, SK.`,
Severity: Major
Found in Website/src/app/services/tournaments.service.ts and 1 other location - About 4 hrs to fix
Website/src/app/services/tournaments.service.ts on lines 29..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    2016: {
      Theme: 'theme-2016',
      Contingents: [ ...this.provinces ],
      Logo: 'http://mbacnationals.com/2016/images/Logo.png',
      Header: 'http://mbacnationals.com/2016/images/background.jpg',
Severity: Major
Found in Website/src/app/services/tournaments.service.ts and 2 other locations - About 3 hrs to fix
Website/src/app/services/tournaments.service.ts on lines 130..149
Website/src/app/services/tournaments.service.ts on lines 150..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    2014: {
      Theme: 'theme-2014',
      Contingents: [ ...this.provinces ],
      Logo: 'http://mbacnationals.com/2014/images/2014_logo.png',
      Header: 'http://mbacnationals.com/2014/images/header_bkg.jpg',
Severity: Major
Found in Website/src/app/services/tournaments.service.ts and 2 other locations - About 3 hrs to fix
Website/src/app/services/tournaments.service.ts on lines 110..129
Website/src/app/services/tournaments.service.ts on lines 130..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    2015: {
      Theme: 'theme-2015',
      Contingents: [ ...this.provinces ],
      Logo: 'http://mbacnationals.com/2015/images/2015_logo.png',
      Header: 'http://mbacnationals.com/2015/images/header_bkg.jpg',
Severity: Major
Found in Website/src/app/services/tournaments.service.ts and 2 other locations - About 3 hrs to fix
Website/src/app/services/tournaments.service.ts on lines 110..129
Website/src/app/services/tournaments.service.ts on lines 150..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status