Sign upLogin

CamiloMM/avisynth

View on GitHub
Star

Showing 16 of 16 total issues

Function Script has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

function Script(code) {
    // Raw copy of the code.
    this.rawCode = code || '';

    // These references work like in the loader. See loader.js.
Severity: Minor
Found in code/script.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processAutotype has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

function processAutotype(param) {
    if (/a/.test(param.m)) {
        // Auto-parameters should guess what the value is supposed to mean.
        // If it's a number or boolean, just output it as is.
        // But if it's a string, it depends on whether it can also be a type.
Severity: Minor
Found in code/newplugin.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Script has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Script(code) {
    // Raw copy of the code.
    this.rawCode = code || '';

    // These references work like in the loader. See loader.js.
Severity: Major
Found in code/script.js - About 2 hrs to fix

    Function pluginImplementation has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function pluginImplementation(name, options, processParameter) {
    return function() {
        // Construct parameter definitons.
        var definitions = [];
        if (options.params) {
    Severity: Major
    Found in code/newplugin.js - About 2 hrs to fix

      Function info has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Script.info = function(scriptPath, cwd, callback) {
    var arg = ['-m', scriptPath];
    system.spawn(system.avsinfo, arg, cwd, true, function(code, stdout, stderr) {
        if (code && code !== 2) {
            // This probably means status code 5, which happens on crashes,
      Severity: Major
      Found in code/script.js - About 2 hrs to fix

        Function createPlugin has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        function createPlugin(name, options, types) {

    // Lazyness taken to new heights. First parameter can succintly describe some filters.
    // If combined with defining the second parameter, that will represent the types.
    if (name.indexOf('(') !== -1) {
        Severity: Minor
        Found in code/newplugin.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function load has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.load = function(file, ignoreErrors, references) {
    file = path.resolve(file);
    if (!utils.isValidPath(file)) throw new AvisynthError('Path contains invalid characters!');
    references = references || exports.references;
        Severity: Minor
        Found in code/loader.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function spawn has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.spawn = function(cmd, args, cwd, internal, callback) {
    // Internal calls can make the callback recieve extra info.
    if (!callback) {
        callback = internal;
        internal = false;
        Severity: Minor
        Found in code/system.js - About 1 hr to fix

          Function spawn has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.spawn = function(cmd, args, cwd, internal, callback) {
    // Internal calls can make the callback recieve extra info.
    if (!callback) {
        callback = internal;
        internal = false;
          Severity: Minor
          Found in code/system.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function processColor(param) {
    if (/c/.test(param.m)) {
        param.value = colors.parse(param.value);
    }
}
          Severity: Minor
          Found in code/newplugin.js and 1 other location - About 50 mins to fix
          code/newplugin.js on lines 199..203

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function processPath(param) {
    if (/[fp]/.test(param.m)) {
        param.value = path.resolve(param.value);
    }
}
          Severity: Minor
          Found in code/newplugin.js and 1 other location - About 50 mins to fix
          code/newplugin.js on lines 237..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                          if (!/^[a-z_][0-9a-z_]*$/i.test(param.value)) {
                    throw new AvisynthError('bad syntax for variable name "' + param.value + '"!');
                }
          Severity: Major
          Found in code/newplugin.js - About 45 mins to fix

            Function addPlugin has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            var addPlugin = exports.addPlugin = function(name, options, code) {
    if (!code) { code = options; options = {}; }

    // Do not add a plugin twice, and avoid name collisions.
    var lowercase = name.toLowerCase();
            Severity: Minor
            Found in code/plugins.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function spawn has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            exports.spawn = function(cmd, args, cwd, internal, callback) {
            Severity: Minor
            Found in code/system.js - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                  return +value == value;
              Severity: Major
              Found in code/utils.js - About 30 mins to fix

                Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.parse = function(color) {
    // A valid number.
    if (typeof color === 'number' && color >= 0 && color <= 0xFFFFFF) {
        return hexColor(Math.round(color));
    }
                Severity: Minor
                Found in code/colors.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language