Sign upLogin

CartoDB/Windshaft

View on GitHub
Star
examples/viewer/leaflet.utfgrid.js

Summary

Maintainability
D
2 days
Test Coverage

File leaflet.utfgrid.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// https://github.com/danzel/Leaflet.utfgrid/blob/18b7043c4a8ac19d4a06658b26e165fb02b8cf1b/src/leaflet.utfgrid.js
// Copyright 2012 David Leaver
// MIT License
L.Util.ajax = function (url, timeout, success, error) {
Severity: Minor
Found in examples/viewer/leaflet.utfgrid.js - About 3 hrs to fix

    Function ajax has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    L.Util.ajax = function (url, timeout, success, error) {

    if (window.XMLHttpRequest === undefined) {
        error(new Error("XMLHttpRequest is not supported"));
    }
    Severity: Minor
    Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    UtfGrid has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    L.UtfGrid = (L.Layer || L.Class).extend({
    includes: L.Mixin.Events,
    options: {
        subdomains: 'abc',
    Severity: Minor
    Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

      Function _update has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          _update: function () {

        var bounds = this._map.getPixelBounds(),
            zoom = this._map.getZoom(),
            tileSize = this.options.tileSize;
      Severity: Minor
      Found in examples/viewer/leaflet.utfgrid.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _move has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          _move: function (e) {
        var on = this._objectForEvent(e);

        if (on.data !== this._mouseOn) {
            if (this._mouseOn) {
      Severity: Minor
      Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _update: function () {

        var bounds = this._map.getPixelBounds(),
            zoom = this._map.getZoom(),
            tileSize = this.options.tileSize;
      Severity: Minor
      Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

        Function _loadTileP has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _loadTileP: function (zoom, x, y) {
        var head = document.getElementsByTagName('head')[0],
            key = zoom + '_' + x + '_' + y,
            functionName = 'lu_' + key,
            wk = this._windowKey,
        Severity: Minor
        Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

          Function ajax has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          L.Util.ajax = function (url, timeout, success, error) {

    if (window.XMLHttpRequest === undefined) {
        error(new Error("XMLHttpRequest is not supported"));
    }
          Severity: Minor
          Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

            Function _finish_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                _finish_request: function (key) {
        // Remove from requests in process
        var pos = this._requests_in_process.indexOf(key);
        if (pos >= 0) {
            this._requests_in_process.splice(pos, 1);
            Severity: Minor
            Found in examples/viewer/leaflet.utfgrid.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        seTilePoint = new L.Point(
                Math.floor(bounds.max.x / tileSize),
                Math.floor(bounds.max.y / tileSize)),
            Severity: Minor
            Found in examples/viewer/leaflet.utfgrid.js and 1 other location - About 55 mins to fix
            examples/viewer/leaflet.utfgrid.js on lines 198..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var nwTilePoint = new L.Point(
                Math.floor(bounds.min.x / tileSize),
                Math.floor(bounds.min.y / tileSize)),
            Severity: Minor
            Found in examples/viewer/leaflet.utfgrid.js and 1 other location - About 55 mins to fix
            examples/viewer/leaflet.utfgrid.js on lines 201..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status